Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by aliask - 2007-01-21
Last edited by jdgordon - 2007-08-05

FS#6555 - Volume limiter

As per a request from a friend I've implemented a feature from the iPod original firmware, volume limiting.
You can set a maximum volume, and while in the WPS you can't increase the volume past that point, to avoid blowing up your ears.
The patch has only been tested in the sims, and it bumps the config block version so you'll need to save your settings.

Closed by  jdgordon
2007-08-05 10:53
Reason for closing:  Out of Date
Additional comments about closing:  

if someone wants to start this again, imo it shuold be added to setvol() in misc.c and not touch any firmware/ code

This patch is out of sync with current svn. Please update it because it would be really usfull!

Your wish is my command.

Just to tell you, it is still out of sync! it still works becasue it is just a hunk that changes the manual! lol, how did that get in there?

Ugh, that file is strange… It's been getting into my patches lately for some reason - svn update doesn't see any difference but svn diff obviously does.
Anyway here's the fixed patch.

Very useful!!!! Safety First^^

sync'ed, can someone please add this already

The patch contains unnecessary (and unwanted) whitespace changes.

can anyone fix it , i have no clue what it means

When you're making a patch you have to be careful not to include tabs. Rockbox source uses 4 spaces for indentation.
Here's the fixed patch.

Sync'ed

patch needs sync, sound.c & sound.h have bin changed

Can someone please add this to the regular builds?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing