• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mikeholden - 2007-02-22
Last edited by BigBambi - 2010-06-05

FS#6686 - Pause screen when adding to playlist

When adding a new playlist to the current playlist, the progress screen flashes past so quickly that you can’t read it.

This patch adds a 2 second pause once the last file has been added, so you can read the status properly.

Closed by  BigBambi
2010-06-05 22:50
Reason for closing:  Rejected

I have also noticed that the message displayed in the splash is bogus (it says to press STOP to interrupt, but it has already finished processing so there is nothing to interrupt).

I will make another version of the patch shortly to address that issue as well.

Please disregard this until then!

New patch.

The following issues are fixed:

1. When finishing inserting or queueing into a playlist, the final status message is displayed for 0 seconds, making it unreadable.

2. When inserting or queueing shorter playlists, the feedback is useless because it only updates every 10 files. Most of my playlists are for albums, and so many contain 9 files or less.

3. Status message at end of insert/queue operation is bogus. It says to press STOP to interrupt, but there is nothing to interrupt as processing of the playlist is already complete.

The fixes are as follows:

1. Completion status splash is now displayed for 2 seconds.

2. When we start to insert/queue, report status every 1 file. After 50 files, switch to reporting every 10 as before. This makes the feedback useful even for smaller playlists.

3. 2 new messages added which don’t mention interrupting the operation.

New version. Fixes minor problem, and sync with latest svn.

Should be good to go now, if anybody feels like testing/committing :-)

Don’t these make the whole process slower? One thing I’ve liked about Rockbox is how quickly one can perform these operations.

Can’t say I’ve noticed an appreciable slowdown. For the most part, the 2 second sleep on the final message is longer than loading the playlist takes anyway!

Synced with latest SVN.

Sync to latest SVN.

I have been using this patch daily since I created it, and it hasn’t skipped a beat. The only concern raised on this tracker and in the mailing list is that the delay is too long, but this was from someone who hadn’t actually used the patch. I have reduced the message wait time to 1 second to address this issue. Apart from that, the main delay still remains that of waiting for the disk to spin up, which is the biggest part of the procedure. This patch doesn’t perceptibly slow anything down.

Any chance this (minor) change could be considered for 3.1?

Actually, missed out the language file diff. The file just uploaded isn’t actually in diff format, simply append the contents to the current english.lang file. I do it this way to get round the problem of svn update barfing on a regular basis because other language strings have been added to the repository.


Available keyboard shortcuts


Task Details

Task Editing