Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by Jacco Koning - 2007-03-05
Last edited by Alex Parker - 2010-06-05

FS#6733 - Shutdown in menu

I think it would be nice if there is an option/submenu shutdown in the main menu.
This can contain the following things
- Shutdown player
- Reboot player (execute the rockbox.iriver file)
- Sleep timer (which is now under info)

I’m owning the iRiver H340, but i think its the same for the other players

Closed by  Alex Parker
2010-06-05 22:53
Reason for closing:  Rejected
2017-01-31 : A request to re-open the task has been made. Reason for request: > Reason for request To provide further information.
Kyle Kamperschroer commented on 2007-03-06 02:22

This is a very neat idea. I really don’t think it would be very hard to implement. I’ll take a look later and see if even someone as stupid with coding as me can figure out how to do it.

Alan F commented on 2007-03-10 15:15

This is be a great idea as I have read a common fault with iriver H120’s is the eventual breaking on the stop button which is also used as shutdown.

I guess it will also reduce wear on similar buttons on other DAP’s.

Robert Keevil commented on 2007-03-10 15:49

Something like this?

Jacco Koning commented on 2007-03-10 16:13

Very nice,
(one small issue: the option ‘shut down’ isn’t correct translated to dutch, it says ‘uitgeschakeld’ (what means ‘disabled’) in stead of ‘uitschakelen’ (= shut down)), but nevertheless it looks very good :)

Jacco Koning commented on 2007-03-10 16:25

I think it’s LANG_SHUTDOWN in de dutch .lang file (German French and English looks good)

Jacco Koning commented on 2007-03-11 17:02

So i’m started with my first rockbox/c programming..
I think i’ve added reboot the patch from obo
It works on my H340, but i can’t test it on other devices
(rolo doesn’t work in the simulator)

Mark Reiche commented on 2007-04-11 16:27

patch is not in sync anymore :-(

Robert Keevil commented on 2007-04-29 22:12

Sync’d. Change sys_poweroff (and hence clean_shutdown and shutdown_hw) so it can reboot instead of halt - should work on all targets without worrying about the status of ROLO, but maybe a bit OTT.

David Maliniak commented on 2007-05-21 01:33

Seems out of sync again, at least for the e200. Causes errors when compiling in power_menu.c.

Dan Everton commented on 2007-07-15 11:43

Resync of the patch. The reboot function doesn’t seem to work on my H120 though.

Robert Keevil commented on 2007-07-29 10:54

Resync, and add a “Rebooting…” splash.

#EDIT#

Binary size increase is 472 bytes for a 5g.

Daniel Dalton commented on 2007-08-20 07:22

I have found a couple of things wrong here.

1. There is an error with power_menu.c about the lang_shutdown. (I have fixed this in my patch)
2. “Shutting down” is broken when turning off the player. I hope to fix this.
3. I can’t really see the point of “Reboot” Can’t we just add an option “Shuttingdown” to the main menu and forget the other stuff?
That way the patch will be smaller and so will the voice file. Why would someone want too reboot there player?
And then just put the sleep timer back where it was before. This way only one option has been added. Of course we could add a quick menu maybe to the main menu and put “Shutdown” in there. And maybe other options later. But I don’t understand why we need “Reboot” as an option.

So if I remove this will that be ok?

I will post my updated patch soon. Just about done. If you aren’t happy with it let me know and I will maybe change it.

Robert Keevil commented on 2007-08-28 22:06

Resync. Add SYS_REBOOT in cases where SYS_POWEROFF is used now to ensure a clean reboot of plugins etc.

As to the point of reboot - it can be useful to get back to the OF, or for a handful of settings that require a reboot of Rockbox to become active. If that is enough to justify the feature or not is another matter.

Daniel Dalton commented on 2007-08-29 06:47

Sorry I didn’t get around to updating. But thanks for the update.
I hope to at some stage make the “Rebooting” splash talk. It shouldn’t be too hard I just need to find where the code should go.
But if someone beats me to it I won’t worry about it.
Does the rebooting function work on any players? If so what players. I got the patch working but I needed to remove something like if(reboot) from it so the rebooting didn’t work it just shutdown the player. But if it is working let me know.
Also if you just want a “shutdown” option in the main menu and no reboot option and the sleep timer to stay where it is then try
 FS#7639 : Shutdown item in main menu.
Thanks.

Jacob Brooks commented on 2007-08-30 00:54

Was getting a hunk error on english.lang kind of resynced. You don’t get a error anymore.

Jacob Brooks commented on 2007-08-30 01:00

Also can this be ported to the gigabeat?

Daniel Dalton commented on 2007-08-30 07:33

Ok I will see what I can do.
I thought it would work with it. I just quickly looked at the code.
Anyway maybe try
 FS#7639 

Robert Keevil commented on 2007-08-30 09:47

Jacob: hunk errors in english.lang aren’t entirely unexpected - any new phrase being added will cause that, just keep moving the ones in this patch to the end. The code /should/ be okay on the Gigabeat - what issues are you seeing? It’s possible that the sys_reboot() function hasn’t been implemented on that platform.

Jacob Brooks commented on 2007-08-31 00:53

I get the below error when I try to compile.

rolo.c: In function ‘rolo_load’:
rolo.c:330: error: too few arguments to function ‘sys_poweroff’ make[1]: * [/rockbox/build/firmware/rolo.o] Error 1
make:
* [build] Error 2

Daniel Dalton commented on 2007-08-31 06:31

What is line 330 in rolo.c?
Also what happens if you build for the h300?

Robert Keevil commented on 2007-08-31 08:38

Jacob: On a clean checkout of SVN, with only this patch applied, I have no problems building for a Gigabeat. firmware/rolo.c is untouched by this patch, (at 328 lines long) so it seems you have one or more other patches applied?

Jacob Brooks commented on 2007-08-31 10:43

It must be the below patch. It is a Gigabeat fast restart.

http://www.rockbox.org/tracker/task/7113

Robert Keevil commented on 2007-08-31 11:00

Change the sys_poweroff() added in the fake-rolo patch to sys_poweroff(false)

Jacob Brooks commented on 2007-10-18 23:25

Resynced

Jacob Brooks commented on 2007-10-18 23:59

Disregard the above patch it won’t compile if applied.

Konstanin commented on 2007-11-17 13:12

Please resync the patch,
it’s usefull

Jacob Brooks commented on 2008-01-16 22:40

Yes, please can someone look into getting this patch to work with SVN.

Robert Keevil commented on 2008-01-16 23:51

Sync’d (and the shutdown and reboot options appear under the System menu…)

Jacob Brooks commented on 2008-01-17 03:39

Thank you very much

Jacob Brooks commented on 2008-01-17 03:40

Now if we could the fast reboot patch synced it would be fantastic.

Jacob Brooks commented on 2008-01-17 13:55

The shutdown option works but when you select reboot it shuts off and never comes back on even when you try pressing the power button. To turn it back on you have to turn off/on the battery switch and then press the power button.

Nikkhil commented on 2008-05-06 10:23

patch synced with current svn & it use to always work with the iriver h10 [20GB] from my end thank you.

Nikkhil commented on 2008-05-18 22:38

patch break during build process at recording.c

Chris Kagan commented on 2008-05-20 20:22

Just a suggestion/request, it would be great if both FS7639 and FS6733 patches were combined to have “Shutdown” in the main menu, “Restart” in the System menu and leave Sleep Timer where it was originally (basically remove that portion of the patch). I’ve used both patches with tdtooke’s Underground build for ipods and these features are very useful!

Jacob Brooks commented on 2008-05-21 00:15
Nikkhil commented on 2008-05-22 11:16

this patch still fails to compile at powermgt.c

Jacob Brooks commented on 2008-06-12 01:06

Try this one

Nikkhil commented on 2008-06-15 00:22

it still fails at recording.c says too few parameters in function “sys_poweroff”

Jacob Brooks commented on 2008-06-15 03:41

It compiles and runs fine on my player and the sim.

Nikkhil commented on 2008-06-15 11:44

hey im using it on the h10[20GB], would that make any difference ?

Jacob Brooks commented on 2008-06-15 13:57

Actually from looking at the patch file this doesn’t even touch recording.c
But if you change sys_poweroff() to sys_poweroff(false) it compiles.

alex wallis commented on 2008-06-23 14:22

Hi. like everyone else, I can’t compile with this patch applied, i’m running an h140, and I can’t compile either with the sim build or the target build.

Nikkhil commented on 2008-06-29 10:55

[quote] But if you change sys_poweroff() to sys_poweroff(false) it compiles.[/quote]

hey yes this works fine compiled at svn.17873, compiles perfect for h10[20GB]

alex wallis commented on 2008-06-29 15:19

Could a version of this patch be uploaded that includes the change? as i can’t see what bit of code to change, and i’m running the last version uploaded.

Robert Keevil commented on 2008-06-29 16:38
Taktak commented on 2008-08-21 10:53

added menu to japanese.lang.

Robert Keevil commented on 2008-12-02 20:25

Synced. shutdown-only.patch only enables the existing Archos Player & Recorder shutdown menu entry for all targets. RAM and binsize cost are 128 bytes. shutdown.patch adds a reboot option - RAM cost is 496 bytes, binsize is 480.

Alexander Levin commented on 2008-12-04 18:52

I would like it very much if the ‘shutdown only’ patch would be included into the official build.

Taylore commented on 2008-12-21 16:11

hmm.. the shutdown (+) (not shutdown only), does not build properly.. MAy someone please resync it please?

Cristiano Rodrigues commented on 2009-02-09 16:02

Some things have changed in the destination files. I made some changes in order to apply the patch. I don’t know if I made the right changes but it is working in my Ipod ver 5.5 80GB

Taylore commented on 2009-02-15 00:35

Yes! Thank you! Works pefectly.. The other one was intrusive, this one is perfect… Thanks again!

Gman commented on 2009-06-19 04:22

Could some one re sync this? Please?

Jacob Brooks commented on 2009-07-24 00:17

Its working fine for me

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing