Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by x1jmp - 2007-03-06
Last edited by jdgordon - 2008-04-24

FS#6747 - y-margin reset in gui_list_draw

When calling a menu function, the y-margin got changed, but was not reset after the function returned.

The patch fixes this behaviour and removes all unnecessary calls to lcd_setmargins from the plugins.

Closed by  jdgordon
2008-04-24 10:42
Reason for closing:  Out of Date
Additional comments about closing:  

should be all fixed (?) now

Damn, reopening because this caused a nasty scroll bug, but this should be done..

x1jmp commented on 2007-03-11 11:40

Task  FS#6796  seems to have fixed the scroll bug.

this was discussed in IRC today and it was bassically decided that storing the x/y pixel value for a scroll line was hacky and not really a good idea, so instead the list widget will be stupid and should be setting the y margin back to old margin when its exited (which isnt know :p ) so we leave it as it is….

ok :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing