• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by maxwen - 2007-03-11
Last edited by Llorean - 2008-01-16

FS#6796 - Put ymargin into scrollinfo

ymargin should be put into scrollinfo like xmargin in startx
so that the scroll_thread becomes independent of any ymargin changes
in the rest of the code during runtime

Tested on X5 and simulators for H120 and IPod Nano

Closed by  Llorean
2008-01-16 14:22
Reason for closing:  Rejected
Additional comments about closing:  

See viewports.

Removed unneeded line in lcd.h

I think this is out of sync. I've tried compiling with the sansa and i get a failed HUNK and an error.

sorry try this one

It stopped compiling today…

CC drivers/lcd-16bit.c
drivers/lcd-16bit.c: In function ‘lcd_puts_customline_scroll_style_offset’:
drivers/lcd-16bit.c:1044: error: ‘struct scrollinfo’ has no member named ‘y_margin’
drivers/lcd-16bit.c: In function ‘lcd_puts_scroll_style_offset’:
drivers/lcd-16bit.c:1125: error: ‘struct scrollinfo’ has no member named ‘y_margin’
drivers/lcd-16bit.c: In function ‘lcd_scroll_fn’:
drivers/lcd-16bit.c:1180: error: ‘struct scrollinfo’ has no member named ‘y_margin’
make[1]: * [/home/diablo/rockbox/sim/firmware/drivers/lcd-16bit.o] Error 1
* [build] Fehler 2

This also happens when I apply ymargin as a single patch.

Here's my personal copy of this patch just in case that'll help:


Available keyboard shortcuts


Task Details

Task Editing