Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by barrywardell - 2007-03-16

FS#6840 - Move rockbox.* into .rockbox

Currently the rockbox.* file is in the root of the device when it’s unzipped from rockbox.zip. For various reasons, the general consensus among developers is that it should be moved inside of .rockbox. This patch does just that for iriver, h10, e200, mi4, ipod, gigabeat and iaudio.

   firmware_in_subdir.patch (0.6 KiB)
Closed by  nls
2007-03-21 00:28
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Barry comitted this

007quick commented on 2007-03-17 18:57

Works fine here. Why not commit it to SVN. Just gotta post a big thing in the formus that everyone should delete the rockbox.file from the root.

jdgordon commented on 2007-03-18 12:09

go for it :)
But is there a version or something in the rockbox. file that can be bumped so we dont have problems with people who left the rockbox. file in /? (unless your patch doesnt try loading that file anymore anyway?)

barrywardell commented on 2007-03-18 17:52

Here's an updated patch. It now does the reverse - the default is to put rockbox.* inside .rockbox except for the cases of rockbox.wma, rockbox.ajz and rockbox.mod. Are these the only three that have to be in the root? Is it even necessary for these three to be in the root?

The manual will also need to be updated. Unfortunately I don't have a build environment up and running for building the manual. Would someone be willing to make the changes?

   firmware_in_subdir.patch (0.6 KiB)
nls commented on 2007-03-20 11:09

I can update the manual when this is comitted :-) The rockbox.ajz and rockbox.mod files need to be in the root because the
original firmware on the archoses loads them on players where rockbox isn't
(or can't be) flashed, and afaik it will only look in the root.
The rockbox.wma is "played" manually to start rockbox on the ifp, i guess
it's placement is for convenience.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing