Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Games
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Jonas Hellesøe Nielsen - 2007-03-18
Last edited by Marianne Arnold - 2007-12-08

FS#6849 - Optimize Bubbles speed using cpu_boost

Many people dont like the fact that when they play music, Bubbles runs very fast, and when the don’t, it’s much slower.

Personally i don’t like it, and the reason to the speed difference is that Bubbles doesn’t boost the cpu like many other speed-requiring plugins do.

This extremely simple (6 lines added!) patch just boost the cpu upon initialization and unboost (or actually it does’t unboost, it just tell rockbox tha it don’t need more boost, but if fx. playback still need boost, it will still be activated) it when exiting.

(This is my first patch, hope i did it the right way)

Closed by  Marianne Arnold
2007-12-08 09:32
Reason for closing:  Rejected
Additional comments about closing:  

Not the right fix, please rather file a bug report or a feature request.

Dominik Riebeling commented on 2007-03-18 15:16

no – you used tabs instead of spaces to indent ;-)

Anyway, I’m not sure if it’s the best solution to simply boost the cpu – shouldn’t it be possible making bubbles respecting the actual cpu speed?

Jonas Hellesøe Nielsen commented on 2007-03-18 15:20

Surely - and boosting uses much more cpu power than “adjusing” bubbles to the cpu. But that’s too advanced for me :D

Arrh- just read the CONTRIBUTING-file 3’rd time, and still forgot the tabs:D

Paul Louden commented on 2007-03-19 16:06

Well the question really ends up “Does bubbles need boost?”

It sounds like it’s running too slow when not boosted, rather than too fast when boosted. I haven’t noticed this personally, but I don’t really run bubbles. But the case may also be that bubbles just can’t run fast enough while music is playing, while unboosted (at least on iPod and other PortalPlayer targets this seems possible) which would suggest either it needs optimized, or it actually needs boosting. (Of course, once whatever’s hindering Dual Core from doing the magic it should be doing gets cleared up, this may be a non-problem.)

So, anyway, when music is not playing, is it as fast boosted as unboosted?

Jonas Hellesøe Nielsen commented on 2007-03-20 12:11

No. While unboosted, it is incredibly slow, and when boosted it’s just as fast as when music is playing (on my iPod Video)

Marianne Arnold commented on 2007-11-30 23:17

Does this entry still need to be open?

- it was never the right fix, I’d rather see a feature request (that bubbles maybe other plugins as well should be able to skip frames if drawing can’t keep up) or a bug report
- with the recent lcd speedups (on many targets) I guess that this problem is not that visible or even present anymore but I don’t have an Ipod Video where it is/was most apparent probably.

I will wait one week for an answer; no answer means I’ll close it, with an answer I’ll decide dependent on that.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing