Rockbox

Tasklist

FS#6918 - Remove Nested Functions

Attached to Project: Rockbox
Opened by Tom Ross (midgey34) - Wednesday, 28 March 2007, 07:50 GMT
Last edited by Tom Ross (midgey34) - Wednesday, 28 March 2007, 08:04 GMT
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The current Rockbox code uses nested functions in dsp.c and radio.c . Nested functions make Mac OS X choke since libtool doesn't like them. This patch is for any user that has issues with nested functions in their build environment.

EDIT: here's the output Mac OS X gives after enabling nested functions and while making them static. http://www.pastebin.ca/413253
This task depends upon

Closed by  Michael Sevakis (MikeS)
Thursday, 29 March 2007, 01:56 GMT
Reason for closing:  Accepted
Additional comments about closing:  Accept with some minor changes. Got rid of the rest that I know of too.
Comment by Michael Sevakis (MikeS) - Wednesday, 28 March 2007, 16:03 GMT
Hrm...my fault =:) Some GCC doesn't like them static and they are nonstandard. I do find them very nice in very limited instances but if they're too problematic they should go. pcm_record.c also has a few but obviously you're building something that doesn't have recording.

At first glace I see a bug in end_search in radio.c where you're assigning/comparing the pointer search_dir and not *search_dir.

Loading...