Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by midgey34 - 2007-03-28
Last edited by midgey34 - 2007-03-28

FS#6918 - Remove Nested Functions

The current Rockbox code uses nested functions in dsp.c and radio.c . Nested functions make Mac OS X choke since libtool doesn’t like them. This patch is for any user that has issues with nested functions in their build environment.

EDIT: here’s the output Mac OS X gives after enabling nested functions and while making them static. http://www.pastebin.ca/413253

Closed by  MikeS
2007-03-29 01:56
Reason for closing:  Accepted
Additional comments about closing:  

Accept with some minor changes. Got rid of the rest that I know of too.

MikeS commented on 2007-03-28 16:03

Hrm…my fault =:) Some GCC doesn’t like them static and they are nonstandard. I do find them very nice in very limited instances but if they’re too problematic they should go. pcm_record.c also has a few but obviously you’re building something that doesn’t have recording.

At first glace I see a bug in end_search in radio.c where you’re assigning/comparing the pointer search_dir and not *search_dir.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing