Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2007-03-31

FS#6948 - Fix the broken 'follow playlist' feature

Here’s a patch for the broken ‘follow playlist’ feature. The bug was reported on irc on Mar 30, 2007, 22:32:29 as follows:

On my H120, I press NAVI while in wps. And the folder the song is in is _not_ shown.

I’ve tested the patch on the sim for H120. It seems to fix the problem.

(application/octet-stream)    follow_playlist.patch (1.5 KiB)
Closed by  roolku
2007-03-31 22:01
Reason for closing:  Accepted
fml2 commented on 2007-03-31 21:09

Here’s a better patch. The old code in the function “browser” did look right, so the error must have been somewhere else. And yes: it was in “load_screen”. The value of the variable “last_screen” was changed too early.

Hopefully this will get committed.

(application/octet-stream)    follow_playlist2.patch (1.5 KiB)
Rincewind commented on 2007-03-31 21:40

I tested the patch and it is working. If the DEBUGF() lines are taken out again, I think this can be commited.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing