FS#6994 - Make some WPS tags more consistent

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Sunday, 08 April 2007, 08:22 GMT
Task Type Feature Requests
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


As of now, %cP produces "am/pm" and %cp produces "AM/PM" (lowercase produces uppercase and vice versa). I think this should be changed.

Another proposal: let's make the RTC tags "atomic", i.e. let's write "%ca %cb" instead of "%ca bc". The parsing will become simpler as well as handling as well as they will be more like other tags (each %-tag produces a piece of information and stands on its own). There are no other tags that require a terminating char.
This task depends upon

Closed by  Bj√∂rn Stenberg (zagor)
Tuesday, 10 April 2007, 13:38 GMT
Reason for closing:  Fixed
Additional comments about closing:  Closing all feature requests.
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 08 April 2007, 21:12 GMT
About the second proposal: It would sure make the parsing code simpler, but the displaying part would be much the same, as the current RTC tag is already broken down into a set of almost independent tokens. Almost because the code still relies on the presence of a leading plain RTC token, but that could be changed.
So it wouldn't be hard to do and it would bring some benefit, but it would break existing WPSes. We have to decide whether it's worth it. Same goes with the first proposal.
Comment by Alexander Levin (fml2) - Monday, 09 April 2007, 07:33 GMT
I've searched for the RTC tags in the WPS's included with RB. There is only one WPS that has it, so only one .wps file would need adjustment.
Comment by Nicolas Pennequin (nicolas_p) - Monday, 09 April 2007, 11:50 GMT
True, but you can be sure that there will be a LOT of forum posts and IRC questions of people asking why the clock their custom WPS doesn't work anymore. People don't like changes like that unless they are really necessary or bring big improvements.