Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Critical
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by stripwax - 2007-04-09
Last edited by nicolas_p - 2007-04-10

FS#7000 - Fixes scroll line behaviour for dynamic tags in new WPS code

The new WPS code is broken for scrolling lines that contain dynamic info (– I think – certainly all ‘next track’ metadata tags are broken and don’t scroll)

Reason is, the line is repeatedly reprinted (via puts_scroll) which has the effect of resetting the scroll x-offset, giving the impression it isn’t actually scrolling at all.

New WPS code wasn’t respecting the WPS_REFRESH_SCROLL flag in refresh_flags

(application/octet-stream)    wps_scroll_fix.patch (1.9 KiB)
Closed by  nicolas_p
2007-04-10 17:17
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed, thanks

nicolas_p commented on 2007-04-10 16:34

from the reopening message:
This seems to break dynamic data that ticks dynamically during playback on scrolling fields! Oops. %s%ar%pc no longer updates , for example. So this is still critical.

nicolas_p commented on 2007-04-10 17:16

The problem with %s%ar%pc was already there in the pre-tokenizer code (I just checked). This means it’s a different issue and it should be reported as a separate entry.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing