Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2007-04-09

FS#7001 - Make rtc tags atomic, no more rtc format

This is the patch for the second part of the request  FS#6994 . It changes the RTC tags so that each tag produces a piece of text.

Before this patch: %cd m yc
After this patch: %cd %cm %cy

I.e. there are now many %cX tags. The terminating c in the RTC tags is not needed anymore.

This introduces incompatibility with the existing RTC tags. WPS’s included with RB are updated in this patch.

The parser has become more elegant IMO. The code in gwps-common.c has become uglier at one place since the structure cur_time is filled not directly at the place where it’s used.

(application/octet-stream)    wps_rtc_tokens.patch (15.7 KiB)
Closed by  nicolas_p
2007-04-10 13:37
Reason for closing:  Accepted
Additional comments about closing:  

Committed, thanks

nicolas_p commented on 2007-04-09 14:14

Does this help binsize ?
I like the idea and the patch, but whether to commit it or not isn’t really my decision to make. Maybe you should try raising the issue on the IRC channel to see how well it’s received.

fml2 commented on 2007-04-09 18:53

As some code has been deleted I think that the bin size is reduced by this patch.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing