- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface → Themes
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#7001 - Make rtc tags atomic, no more rtc format
This is the patch for the second part of the request FS#6994 . It changes the RTC tags so that each tag produces a piece of text.
Before this patch: %cd m yc
After this patch: %cd %cm %cy
I.e. there are now many %cX tags. The terminating c in the RTC tags is not needed anymore.
This introduces incompatibility with the existing RTC tags. WPS’s included with RB are updated in this patch.
The parser has become more elegant IMO. The code in gwps-common.c has become uglier at one place since the structure cur_time is filled not directly at the place where it’s used.
Closed by nicolas_p
2007-04-10 13:37
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2007-04-10 13:37
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Committed, thanks
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Does this help binsize ?
I like the idea and the patch, but whether to commit it or not isn’t really my decision to make. Maybe you should try raising the issue on the IRC channel to see how well it’s received.
As some code has been deleted I think that the bin size is reduced by this patch.