Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Porphyr - 2007-04-09

FS#7002 - Fix bug in parser of tagnavi.config

This fixes a small but very nasty bug: If you only specify one menu in your tagnavi_custom.config file and you want to set this as a root_menu, your choice will be overwritten by the root_menu in the default tagnavi.config file. The reason for this is the double meaning of root_menu == 0 - it means both “not yet set” and also “first menu is root_menu”.

I fixed this bug by first initialising root_menu with -1 (allowing overwriting of root_menu while parsing only if it is still == -1); after parsing is done, root_menu will be set to zero if it is still -1 (this keeps the old behaviour: if you don’t specify root_menu, take the first menu)

Closed by  miipekk
2007-04-12 18:34
Reason for closing:  Accepted

Thanks again, committed :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing