Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Feature Requests
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Ken Williams - 2007-04-12
Last edited by Nicolas Pennequin - 2007-04-12

FS#7020 - Allow number sign (#) to be displayable in WPS

It would be nice to be able to display a number sign in the WPS.
eg Track #3
I believe this could be achieved by treating %# like the other escaped characters.
eg %%, %<, %|, etc.

I made a simple patch which adds “case ‘#’:” to the other escaped character cases in apps/gui/wps_parcer.c
but I think this breaks other # behaviour.
ie “# This is a comment” added to the end of a line will actually show up in the WPS after my patch is applied.
Therefore, I’m afraid this fix must be more involved and goes beyond my limited programming skills.

I could attach my patch, if necessary, but, as I said, it is merely the addition of the one line of code.

Closed by  Björn Stenberg
2007-04-13 11:43
Reason for closing:  Fixed
Additional comments about closing:  

Closing all feature requests.

Nicolas Pennequin commented on 2007-04-12 23:49

It’s already possible to display a # in a WPS, but it needs to be in a string. This means it can’t come right after a tag or at the beginning of a line.

Ken Williams commented on 2007-04-13 07:59

I see.
I used to have the following line in a WPS:
%ac%s%?in<#%in >%?id<on %id>
It stopped working with the changes to WPS Tokenizer (removing the entire line from the display), so I assumed #s within lines wouldn’t work at all.

It turns out I can almost achieve the same thing with the following:
%ac%s%?in< #%in >%?id<on %id> –essentially making " #” a string, I guess.
It does however put a gap at the start of the line when scrolling, or sets the line slightly off-center when shorter than the screen width.

I can live with it. I was just hoping it wouldn’t be too difficult for someone to implement the addition I suggested: making an escaped # so it could be displayed anywhere in the WPS.

If it can’t be done, go ahead and close this feature request.

Admin
Linus Nielsen Feltzing commented on 2007-04-13 08:02

I think escaping it is the far better solution.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing