Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Nicolas Pennequin - 2007-04-15
Last edited by Jonathan Gordon - 2008-09-23

FS#7033 - Define line height in the WPS

This patch adds an %lh tag to the WPS that allows to define the line height.
The format is %lh|height| (the ‘|’ at the end is mandatory).
With this tag added to a WPS, the lines will be of the specified height whatever the font chosen by the user.
If the font used is smaller than the defined line height, the text will be centered.

Closed by  Jonathan Gordon
2008-09-23 10:17
Reason for closing:  Out of Date
Additional comments about closing:  

this is less of an issue now the WPS has viewports so can probably be closed

Nicolas Pennequin commented on 2007-04-16 23:04

A few minor updates, and the tag is now %ls because %lh was already taken (silly me !).

Dave Chapman commented on 2007-04-17 07:43

Going by the discussion in IRC (2007-04-17, starting at 00.12.56), there seem to be some objections to this patch, so I thought I would comment to say I’m in favour of committing it.

The code changes seem very minimal (mainly just replacing references to the font height to references to this new variable), and it implements two (IMO useful) features - 1) The ability for a WPS designer to specify a line-spacing; 2) The ability for a user to use slightly different sized fonts with an existing WPS without breaking the formatting wrt images. e.g. a user might want to use a smaller font in order to display more text without scrolling.

A side-effect is that WPSs are less broken when the user doesn’t have the correct font installed, but I don’t think that’s the primary reason for committing this patch.

Nicolas Pennequin commented on 2007-04-25 01:17

This patch has an issue with scrolling lines: they don’t take the line height setting into account.
I will try to find a nice workaround, but it seems amiconn’s viewports and LCD drivers rewrite will bring the true solution to this.

Nathan Hale commented on 2007-05-13 16:46

NicolasP, do you have time to sync this patch or have you abandoned it due to the mentioned viewports and LCD drivers rewrite?
Thanks.

Nicolas Pennequin commented on 2007-05-13 17:06

I haven’t had the time to have a close look at the problem and I’m not sure I will in the next few days, but I’ll try not to forget this patch :)
Until then, here is my latest version (I’m not sure there are some changes but at least it’ll apply cleanly)

Nathan Hale commented on 2007-05-13 22:20

Cool! Thanks! I definitely understand there not being enough hours in the day. Thanks for the response, though.

Jonathan Gordon commented on 2008-01-08 05:37

here is my 30min half assed attempt at getting this working in the viewport code for 16-bit lcd. I gave up because I couldnt be bothered trying to get the selection bar working properly… if someone wants to fix it properly please go for it :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing