Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category LCD
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tfact - 2007-04-17
Last edited by pondlife - 2007-04-17

FS#7045 - Fix bug in font.c

bug fix
Font breaks when MAX_FONT_SIZE is 0xFFFF or more.

   font.patch (0.8 KiB)
Closed by  Llorean
2007-04-17 18:22
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

This fixes a \"bug\" that only exists if the user changes the value of a #define beyond its expected range (65535) and so is not suitable for inclusion in SVN (adds code that serves no purpose except in user-modified builds)

Llorean commented on 2007-04-17 17:59

How is this a bug, if MAX_FONT_SIZE is defined to be less than that?

tfact commented on 2007-04-17 18:08

Font not breaks when MAX_FONT_SIZE is defined to be less than that.

The display quickens when unicode font is used when the MAX_FONT_SIZE is enlarged.

(ex. unifont.fnt is 1.3MB)

Llorean commented on 2007-04-17 18:09

But MAX_FONT_SIZE does not need to be enlarged. The whole point of the glyph cache is so that the whole font doesn’t get loaded.

So, to be clear: This is only a bug if the User modifies MAX_FONT_SIZE, right?

tfact commented on 2007-04-17 18:16

Yes.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing