Rockbox

Tasklist

FS#7045 - Fix bug in font.c

Attached to Project: Rockbox
Opened by takka (tfact) - Tuesday, 17 April 2007, 16:08 GMT
Last edited by Steve Bavin (pondlife) - Tuesday, 17 April 2007, 16:55 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System All players
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

bug fix
Font breaks when MAX_FONT_SIZE is 0xFFFF or more.

   font.patch (0.8 KiB)
This task depends upon

Closed by  Paul Louden (Llorean)
Tuesday, 17 April 2007, 18:22 GMT
Reason for closing:  Rejected
Additional comments about closing:  This fixes a \"bug\" that only exists if the user changes the value of a #define beyond its expected range (65535) and so is not suitable for inclusion in SVN (adds code that serves no purpose except in user-modified builds)
Comment by Paul Louden (Llorean) - Tuesday, 17 April 2007, 17:59 GMT
How is this a bug, if MAX_FONT_SIZE is defined to be less than that?
Comment by takka (tfact) - Tuesday, 17 April 2007, 18:08 GMT
Font not breaks when MAX_FONT_SIZE is defined to be less than that.

The display quickens when unicode font is used when the MAX_FONT_SIZE is enlarged.

(ex. unifont.fnt is 1.3MB)
Comment by Paul Louden (Llorean) - Tuesday, 17 April 2007, 18:09 GMT
But MAX_FONT_SIZE does not need to be enlarged. The whole point of the glyph cache is so that the whole font doesn't get loaded.

So, to be clear: This is only a bug if the User modifies MAX_FONT_SIZE, right?
Comment by takka (tfact) - Tuesday, 17 April 2007, 18:16 GMT
Yes.

Loading...