• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by fml2 - 2007-04-24

FS#7078 - Display a message if there is no playlist to view (fix for FS#7027)

This is a fix for the bug reported in  FS#7027 

Closed by  jdgordon
2007-04-26 08:21
Reason for closing:  Accepted
fml2 commented on 2007-04-24 20:54

Ah, petur, I’ve just noticed your comment in the bug report. And you’re probably right. So I’m not sure anymore that this patch fixes the problem! :-)

fml2 commented on 2007-04-25 06:37

I still think that a message should be shown. The problem is that the check whether a list is present is wrong. It has false negatives, i.e. says that no list is available when there is one. This e.g. the case when the playback is paused. But if the list was played to the end then there is really no list to view. Resume playback will tell you “Nothing to resume.” So the check must be somehow synchronized with the check in ‘resume playback.’

I had a quick try getting the playlist viewer to load the playlist from the resume info, but for some reason it likes crashing… so its more than a quick fix :(

fml2 commented on 2007-04-25 17:49

This seems to work as defined by petur: if resume playback is possible, you’ll be able to view the playlist.

that works? hmm… its bassically exactly what tried but it kept crashing the sim..

anyway, I dont think we need a new lang string for this, “No Playlists” is fine here imo.

fml2 commented on 2007-04-26 07:31

This worked for me at least. Other testers are welcome. And I think we need a specific message. “No Playlists” doesn’t fit the context IMO.

well, the reason I say we shouldnt add another string for this is because its not worth the added space imo.. “No Playlists” is close enough to near enough for this context to be fine. thats the only reason I havnt commited it yet.


Available keyboard shortcuts


Task Details

Task Editing