Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Battery/Charging
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by Simon Menzel - 2007-04-30
Last edited by Frank Gevaerts - 2011-06-04

FS#7092 - Estimated Runtime Scaling

This patch adds a new Setting “System → Battery → Estimated Maximum Runtime”. Users can set the maximum runtime they get on average.
This value is then used to scale the estimated runtime display in the info screen and the WPS tag.

This is useful when when the battery is very old and on targets where the runtime display isn’t calibrated very well.
A similar effect could be achieved with changing the battery capacity value, but this may have unwanted side effects and is not very
userfriendly.

Should work on all targets (someone should check my code for the archos players, though).

Closed by  Frank Gevaerts
2011-06-04 21:28
Reason for closing:  Out of Date
Jonathan Gordon commented on 2007-04-30 13:22

patch looks ok (havnt actually tested it though), except your adding the new var in the settings struct in the middle... it needs to go at the end unless we want the plugin version to be bumped

Simon Menzel commented on 2007-04-30 13:48

fixed.

Sal commented on 2007-08-03 18:25

both patches failed in a few spots the one in comments failed in 3 hunks

Dave Germiquet commented on 2007-08-27 00:33

Does this work? I patched it and then edited the rejects I don’t see the option under System/Battery?

Simon Menzel commented on 2007-08-27 10:15

there have been quite a few changes to the power management code. I’m afraid this patch doesn’t work
fix it in the next few days.

Jack Suter commented on 2007-08-27 14:12

Works fine on the Sansa. I had to change the code a little because they battery menu was removed. I don’t have a copy of the patch (directly edited parts of the source to make it work) though I might be able to get one working. If you re-enable the battery menu (IIRC, it’s just an if statement) you should have it working again.

Chris commented on 2007-09-05 09:50

Perhaps use svn diff feature to generate a patch?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing