FS#7093 - Latest WPS parser change lets long strings crash rockbox - fix

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Monday, 30 April 2007, 21:38 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Some buffer overruns in latest wps_parser.c change. Patch attached.
This task depends upon

Closed by  Peter D'Hoye (petur)
Tuesday, 01 May 2007, 23:36 GMT
Reason for closing:  Accepted
Comment by Dave Hooper (stripwax) - Monday, 30 April 2007, 22:25 GMT
improved patch. Previously we'd stop reading literal strings when the string buffer was full, regardless of whether the new string literal is a duplicate or not. Now we output a text token if the newly read string is a dupe even when the string buffer is already full. This hopefully gives the most benefit
Comment by Dave Hooper (stripwax) - Tuesday, 01 May 2007, 23:07 GMT
Removed extraneous printf. Reduced length of long lines.