Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System Sansa e200
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by donutman25 - 2007-05-04
Last edited by jdgordon - 2007-08-06

FS#7105 - Music Led

First attempt to make the scrollwheel led beat to the music. Only tested it with the ipod_sansa theme. Please tell me if you experience bugs. Feel free to improve this because i have no programming knowledge.

   music_led.patch (0.4 KiB)
Closed by  jdgordon
2007-08-06 02:29
Reason for closing:  Rejected
donutman25 commented on 2007-05-04 06:17

It does not work with themes that do not have the peak meter enabled. I’m gonna work more on this tomorrow. Its late and i have school in the morning.

donutman25 commented on 2007-05-05 02:12

Small change to make the scrollwheel more sensitive to the changes in dbfs. I think :|

   music_led.patch (0.4 KiB)
disorganizer commented on 2007-06-13 21:44

it would maybe be a good idea to check the scrollwheel light setting to enable or disable this patch via settings. if scrollwheel light is set to off then the patch should imho be disabled.
or maybe even only enable it when the scrollwheel is set to permanent on.

that way i can use the peakmeter in builds with included music-led patch :-)

Aarto commented on 2007-06-13 21:57

I’d like to have a separate settings for this feature, it shouldn’t depend on scrollwheel settings.

chrisjs169 commented on 2007-06-14 21:43

Since most WPSs look bad with the peakmeter in them, shouldn’t the complaint be having a setting to turn it on without %pm in the WPS file, not the other way around? IMO it’s already ‘off’ by default (unless you’re using the default rockbox theme)

disorganizer commented on 2007-06-15 10:34

good point. maybe it could be a % directive in the WPS file to trigger the musicled feature.

Aarto commented on 2007-06-18 21:36

the better idea is to realize it as a plugin, thus it won’t be necessary to worry about %pm tag or adjusting the scrollwheel light
to use the feature when you need it only

disorganizer commented on 2007-06-20 09:32

i think its own % tag for the wps would be the better idea because you can easily turn it off when switching the wps (for example no blinking in car-wps, but blinking in mobile-wps).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing