Rockbox

Might I suggest you do those things for us. If you want stuff like this to be commited you need to make it as easy as possible to do. I would suggest that you just pick an icon for now, or have no icon.

OK Done. This will patch against current SVN.
TODO additional formatting. It is almost not
required on these small screens.

GRaTT

   HTML_Parser.diff (8.7 KiB)

Added: formatting on <P> and <BR> tags.
Looks much better now.
Added: support for nested tags, it cleans up some stuff.
A bad HTML page will give a bad conversion.
If a closing > is missed then all the following text will
be discarded.

patch -p0 < HTML_ParserV1.1.diff
Nothing additional required.
GRaTT

And here is the file

   HTML_ParserV1.1.diff (10.2 KiB)

minor update
When the parser exits the created text file is highlighted
in the directory view.
GRaTT

   HTML_ParserV1.2.diff (10.1 KiB)

one more minor update
added 2 to the filetypes array for htm and html
GRaTT

   HTML_ParserV1.2.diff (10.5 KiB)

updated for changes to plugin directories.
Use of CATALOG file and adds htm and html fyle types.
increase file type array by two (2).
GRaTT

   HTML_ParserV1.3.diff (10.8 KiB)

Above was supposed to say
Use of CATAGORIES file

fixes a hang if plugin run as a plugin and not a viewer.
GRaTT

   HTML_ParserV1.4.diff (15.3 KiB)

I know you want to advertise your other patches, but I already have the calendar patch :P

Here’s a copy without part of the calendar patch:

   HTML_ParserV1.5.diff (10.7 KiB)

Once again thanks jack.
I was heading out of town and trying to get a few things done.
I was not trying to force another patch on anyone.
GRaTT

I know, I sometimes make mistakes when I start to get rushed too (j/k about you trying to advertise your other patches)

-Jack

Removed changes to filetypes.c as no longer needed.
I tried to open the text viewer automatically with the
created text file by adding the function plugin_load()
to plugin.(c/h). It worked great to open and use but on
exit of the text viewer I allways got an undef instruction.
Anybody know of a way to successfully open and close a plugin
from a plugin??
GRaTT

   HTML_ParserV1.6.diff (10.4 KiB)

Sync and some clean up.

Also, make sure that the trailing ‘\0’ of your header/footer strings doesn’t go into the text file, all text editor I tried (I tried some 7-8) had problems.

I also did some simplification: replace snprintf with strcpy (I wonder why you used snprintf in the first place). Also, there’s no need to rb→write every single byte in a loop, just write all at once. Removed some uneeded variables.

   HTML_ParserV1.7.diff (10.7 KiB)

Fix red :/

Even though the simulator worked just fine, there was a weird error while compiling a test build.

   HTML_ParserV1.8.diff (10.7 KiB)

cant get that compiled :(