Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nicolas_p - 2007-05-13

FS#7164 - FS#6780: Improve WPS volume conditional

This patch implements the feature requested in  FS#6780  and discussed in http://forums.rockbox.org/index.php?topic=10418.0.
the volume enum is now %?pv<Mute|…|…|0 dB|Above 0 dB> for targets that can go above 0 dB, and %?pv<Mute|…|…|0 dB> for targets that can’t.

Closed by  nicolas_p
2007-05-14 14:37
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Committed

Having two different cases is a bad idea because it hurts WPS portability. The volume enum is now %?pv<Mute|…|…|0 dB|Above 0 dB> for all targets. On targets that can’t go above 0 dB, the last case will never be used.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing