• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pondlife - 2007-05-16
Last edited by jdgordon - 2007-05-20

FS#7176 - Reshuffle changes playlist context menu position

1) Play a playlist - I’m using a large one (12000 entries) generated from the database, though that’s probably not relevant.
2) On the WPS, hold SELECT.
3) Go down to “Playlist” and press RIGHT.
4) Go down to “Reshuffle” and press RIGHT.

Actual result: The context menu is displayed with “Set Song Rating” as the selected entry.
Expected result: The context menu is displayed with “Playlist” as the selected entry. Or a splash is displayed to show Reshuffle performed and the Playlist menu is still displayed with “Reshuffle” selected.

Closed by  jdgordon
2007-05-20 14:24
Reason for closing:  Fixed

Another oddity I noticed, which is probably related; when the Playlist menu is intially selected, pressing PLAY takes me to the WPS (correct). However, if I move down so “Reshuffle” is highlighted, PLAY takes me out to the Context menu. At this point PLAY will take me back to the WPS only if I first press UP or DOWN.

Project Manager

To reproduce this, you have to have “Gather runtime data” enabled in the database settings. I bet this has to do with dynamic menu items in the context menu.

petur commented on 2007-05-19 08:28

I still lost on how this relates to the playlist viewer issue Lamed is experiencing

ok, Linus pretty much led me to the answer straight away, and I think this is correct. The current selection shhuold always be set to the selected item in the menu which do_menu() was called from, I think.
so the attached diff does this, and fixes the bug.

I didnt commit because I’m not 100% sure this is the correct behaviour, it sounds sane, but… I dunno….

and I agree with Peter, its not related.

test comment to see if I get a php error..

edit; didnt.


Available keyboard shortcuts


Task Details

Task Editing