FS#7258 : new list selection code hopefully fix all existing bugs

Status Closed
Percent Complete
100%
Task Type Patches
Category User Interface
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by jdgordon - 2007-06-04
Last edited by jdgordon - 2007-06-05

FS#7258 - new list selection code hopefully fix all existing bugs

Putting this up to get some feedback before commiting, seen as every time I think its working, someone goes out of their way to proove me wrong :D

This version is simple and has plenty of room for optimizing, but want to make sure it works in all cases before cleaning it up a bit.

list.patch (8.2 KiB)

Closed by jdgordon
2007-06-05 02:57
Reason for closing: Accepted

Comments (5)
Related Tasks (1/0)

pondlife commented on 2007-06-04 09:50

SVN + this patch doesn’t allow the cursor bar to go to the top or bottom of the screen before scrolling. Also the screen is entirely refreshed/scrolled when not needed.

Example, with 18 files in a folder, on H300 sim:
- BEFORE.JPG shows track 06 selected, with track 04 at the top and 14 at the bottom.
- I then press DOWN once to select track 07.
- AFTER.JPG shows track 07 selected, with track 01 at the top and 11 at the bottom. It should have just moved the cursor bar down and not scrolled at all.

before.jpg (22.4 KiB)

after.jpg (22.5 KiB)

jdgordon commented on 2007-06-04 11:51

well, after doing a diff and almost reverting the whole acceleration code, I’ve fixed your bug.

list.patch (8.3 KiB)

jdgordon commented on 2007-06-04 12:32

minor update

list.patch (8.8 KiB)

jdgordon commented on 2007-06-04 14:43

fixed the bug where you could fall off the end.
tries to make sure the first line of a multi-line item isnt the last line on the screen

list.patch (9 KiB)

nicolas_p commented on 2007-06-04 21:13