Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To
    nicolas_p
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 3
  • Private
Attached to Project: Rockbox
Opened by kahuna_999 - 2007-06-11
Last edited by linuxstb - 2008-03-24

FS#7289 - Allow upto 512 images to be used in WPS

This patch adds the ability to display part of a loaded bitmap in the wps.
It still only allows the maximum 52 bitmaps to be loaded but adds a new tag %xp to display upto 512 bitmap parts onto the screen. This partners the existing %xd tag.
Similar to patch  FS#2791  (appears defunct as not updated for over 1 year), but lifts the limit of available image displays to 512.

There are two variations on the command. The first will use the x,y coordinates from the corresponding %xl tag, the second allows you to specify them.

%xp<bitmap load id>|srcx|srcy|w|h|
%xp<bitmap load id>|srcx|srcy|w|h|x|y|

The %xp tag can be used in conditions.

I hope the artists out there can make use of the additional display capabilities and come up with some fancy graphical wps’s

Initial version synced to svn13614

Closed by  linuxstb
2008-03-24 00:09
Reason for closing:  Out of Date
Additional comments about closing:  

Partial bitmap display has now been implemented in SVN with "bitmap strips".

Decided not to overload the %xp tag as it caused too many issues in the conditional tags..

Now have the following two new tags
%xp<bitmap load id>|srcx|srcy|w|h|
%xx<bitmap load id>|srcx|srcy|w|h|x|y|

sync’d (see filename) and updated following forum comments.

Back to a single overloaded tag, but with new parm seperators…

%xp<bitmap load id>:srcx:srcy:w:h
%xp<bitmap load id>:srcx:srcy:w:h:x:y

This makes its use in conditionals _much_ easier to use and read.

I think this patch is a good idea.
However, I don’t see why you had to change the separators from the de facto WPS standard pipe (|).

petur commented on 2007-06-24 13:42

RaeNye, I guess he explained it in the comment just above yours :p

Sync’d to r14667

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing