Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Rbutil
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rasher - 2007-06-12
Last edited by rasher - 2007-06-23

FS#7294 - Use PNGs for buttons

This patch changes Rockbox Utility to use PNGs for the buttons. This has the advantage of allowing much nicer graphics. Right now, the image loading is implemented using external files, but it should certainly be possible to embed them in the executable.

http://wxwidgets.org/wiki/index.php/Embedding_PNG_Images Explains how to convert PNGs to C and then use them like that.

http://www.wxwidgets.org/manuals/stable/wx_wxbitmap.html#wxbitmap Says that images can either be loaded from file or a resource, but I don't know how resources work.

The next problem is I've taken icons from the Tango Desktop project. These icons are available under the Creative Commons Attribution-ShareAlike 2.5 License, which is not GPL compatible so more suitable icons should be found for embedding into the executable.

   rbutil-pngbuttons.patch (3.5 KiB)
   buttons.tar.bz2 (21.7 KiB)
Closed by  rasher
2007-06-23 02:40
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Added to SVN (in a proper version) it seems.

rasher commented on 2007-06-12 15:27

Here's a set of buttons based on gnome-icon-theme, which is licensed under GPL, but looks pretty similar to the "official" tango icons, since they're based on the same guidelines.

Of course, using the Doom logo is probably not too wise either…

   gnome-icon-theme-buttons.tar.... (22.4 KiB)
Domonoky commented on 2007-06-15 21:26

i think we have to embedd those image into the binary, otherwise there are to many needed files.

Afaik loading images from resources is only possible in Winodows, so we should convert those images to C with the bin2c program as it is explained in the first link you gave.

And we should change the doom image..

rasher commented on 2007-06-19 21:04

I agree on all three points, but won't have time to look at this anytime soon.

The best solution would probably be to convert the PNGs at build-time, so the PNGs could be kept as the originals.

For the doom image, I suppose we could use a generic "games" icon from the gnome set (I believe it's a joystick).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing