Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Simulator
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by nls - 2007-06-14
Last edited by nls - 2007-07-31

FS#7311 - 64 bit simulator crashes when using the menus in some plugins.

When using menus in some plugins in the simulator built for AMD64 it crashes with a segfault in settings.c line 424.

I have found two plugin- menues that cause this, the settings menu in the clock pluin and changing meter type in vu_meter with the new menu.

I am running ubuntu 7.04 on AMD64 and using gcc 4.1.2
the clock plugin is confirmed to be working correctly on 32 bit linux and in cygwin as well as on my player (h320)
THe vu_meter men u also works on my player but wasn’t tested on 32 bit sims.

Closed by  nls
2007-07-31 10:55
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Was caused by a naming conflict, the plugins had private structs called 'settings' that they used as parameters in the menu api which confused the settings code, why it only hit 64 bits, IDK…

nls commented on 2007-06-17 08:56
Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

This crash is fixed by jdgordon's patch in the mailing list http://www.rockbox.org/mail/archive/rockbox-dev-archive-2007-06/0050.shtml

pondlife commented on 2007-06-17 16:46

Here's the patch copied from that ML post.

   settings_changes.diff (36.3 KiB)
pondlife commented on 2007-07-30 22:09

Nils, can you confirm this has been fixed in SVN, since JdGordon's patch has now been committed…

nls commented on 2007-07-30 23:27

hmm, nope still segfaults, on a different line this time though…

I get this for both the cases mentioned above with r14085

[Switching to Thread 1090525504 (LWP 19932)]
0x000000000041ffba in is_changed (setting_id=0) at settings.c:390
390 else if (*(int*)setting→setting == setting→default_val.int_)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing