Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System iPod 5G
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by idak - 2007-06-18
Last edited by Llorean - 2007-06-18

FS#7323 - Displaying colors each LCD line does not work in iPod5G

custom_colors[](apps/filetypes.c) is "short" value,
but gui_list→title_color is "int"
(gui_list_draw_smart()(apps/gui/list.c)).
And this causes sign-extension
(0xF000 becomes 0xFFFFF000, it is minus).
So I think rev13660's change is not needed.

Closed by  Llorean
2007-06-18 22:16
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Should still be fixed. If I re-broke it with this last commit, feel free to yell at me again. :)

idak commented on 2007-06-18 15:30

Or unsigned short is needed.

A change has been committed that should fix this. Does it work properly now?

idak commented on 2007-06-18 21:51

It works now :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing