Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Notice: A non well formed numeric value encountered in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 96 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.flyspray.php on line 104 Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /sites/rockbox.org/flyspray/adodb/adodb.inc.php on line 845 Deprecated: Function create_function() is deprecated in /sites/rockbox.org/flyspray/includes/class.user.php on line 111 FS#7323 : Displaying colors each LCD line does not work in iPod5G

Rockbox

Tasklist

FS#7323 - Displaying colors each LCD line does not work in iPod5G

Attached to Project: Rockbox
Opened by Akio Idehara (idak) - Monday, 18 June 2007, 14:18 GMT
Last edited by Paul Louden (Llorean) - Monday, 18 June 2007, 22:16 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

custom_colors[](apps/filetypes.c) is "short" value,
but gui_list->title_color is "int"
(gui_list_draw_smart()(apps/gui/list.c)).
And this causes sign-extension
(0xF000 becomes 0xFFFFF000, it is minus).
So I think rev13660's change is not needed.
This task depends upon

Closed by  Paul Louden (Llorean)
Monday, 18 June 2007, 22:16 GMT
Reason for closing:  Fixed
Additional comments about closing:  Should still be fixed. If I re-broke it with this last commit, feel free to yell at me again. :)
Comment by Akio Idehara (idak) - Monday, 18 June 2007, 15:30 GMT
Or unsigned short is needed.
Comment by Paul Louden (Llorean) - Monday, 18 June 2007, 18:43 GMT
A change has been committed that should fix this. Does it work properly now?
Comment by Akio Idehara (idak) - Monday, 18 June 2007, 21:51 GMT
It works now :)

Loading...