Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by dip - 2007-06-26
Last edited by safetydan - 2007-08-08

FS#7362 - Support for GROUPING tag

This patch adds support for the GROUPING tag which is usually used for grouping titles of multi part works (e.g. classical works like symphonies or sonatas). It supports id3v2.2 (TT1), id3v2.3 and id3v2.4 (TIT1), mp4 (cgrp) and vorbis comments (GROUPING as used by MusicBrainz, CONTENTGROUP as used by MP3Tag and CONTENT GROUP as used by foobar2000). In WPS you can use %iG and %IG. As tagnavi.conf tags “grouping” and “contentgroup” are supported but not “content group” due to the space in the middle.

In addition, when building the database and a track doesn’t have a grouping tag, it copies the value from the title tag. This should make browsing through classcical works in the database a bit nicer since you will find all your music, not only titles having the grouping tag explicitely set (similar to the recent albumartist improvement). You need to rebuild your database to actually see any change.

Closed by  safetydan
2007-08-08 10:30
Reason for closing:  Fixed
Additional comments about closing:  

Patch committed. Thanks.

dip commented on 2007-06-26 23:25

I didn’t mean WPS-tags when mentioning “grouping” and “contentgroup” but the tags for the tagnavi.conf file. (Isn’t there a way to edit my own post?)

dip commented on 2007-07-23 22:00

LinusN already stated in this thread http://forums.rockbox.org/index.php?topic=11173.0 that this patch may be committed. Could some developer please commit it that Rockbox support for classical music is improved?
Thanks a lot.

dip commented on 2007-07-31 20:34

Synced. Needs testing again though and I don’t really have the setup to do that.

dip commented on 2007-08-07 20:51

I tested it with the current svn (r14233M-070807) and it works great.

What’s your real name for the credits? Or are you already in the credits file?

dip commented on 2007-08-08 10:16

My real name is Dieter Pellkofer. I have no idea if I am already in the credits file. The only patch I created and which was committed so long was the album artist and comment patch (which was based on a patch from Robert Kukla). Should I amend my profile to include my complete name, if yes, how can I do that?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing