• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by PaulJam - 2007-06-29
Last edited by pondlife - 2008-02-09

FS#7372 - Rename should fail on invalid userinput.

When the user tries to move a directory inside itself by renaming it (e.g. remame directory “test” to “test/test2”) then the renaming functionalyty doesn’t fail gracefully.
The directory disappears from the filebrowserbrowser in Rockbox and also doesn’t appear in the Windows explorer. When running chkdsk it asks to convert lost chains into files and this restores some (useless) files that contain fragments of the previous contents of the folder.

Also it is possible to use illegal characters in file- and foldernames. See  FS#7222  and  FS#6358 

H300 with version: r13733M-070629

Closed by  pondlife
2008-02-09 14:58
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

petur fixed the outstanding dircache issue recently.

There have been some recent changes to both FAT filename and rename validation - please can you recheck this?

Using illegal characters when renaming doesn’t seem to be possible anymore.
But i was still able to reproduce the first issue (moving a directory into itself via renaming) with revision r13811-070707 on a H300.

Wouldn’t it be possible to just check the target path if it contains the current path of the directory when renaming?
A similar thing seems to be done when trying to do the same with the cut and paste functions from the context menu. Then it just shows a splash with “paste failed” and no harm is done to the filesystem.

Disallowing ‘/’ characters (so you can’t try to change directories via rename) can be done in merely one line. :)

One other thing that’s somewhat related to  FS#6358 : The dircache is updated before a file is actually renamed or removed, making the browser not show things correctly when either fails. It’s an easy fix, though.


Available keyboard shortcuts


Task Details

Task Editing