Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Games
  • Assigned To
    kkurbjun
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by kkurbjun - 2007-06-30
Last edited by kkurbjun - 2007-07-21

FS#7379 - Rockboy sound patch

This is a patch for rockboy that attempts to clean up the sound by adding in sound code from VisualBoy. If you test this please let me know the results including the player used and the game played.

Closed by  kkurbjun
2007-07-21 04:04
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Patch committed to SVN - sound will be different on players that cannot emulate full speed (sound buffers are not improperly repeated any more)

kkurbjun commented on 2007-06-30 20:31

Forgot the file

   rbdiff.diff (7.5 KiB)
xaviergr commented on 2007-06-30 23:17

Plays excellent on my F40. Tremendous difference from the current one in SVN.
Choppy on H300 but that’s because it can’t get more than 50+ fps.

Benjamin_L commented on 2007-07-01 11:25

Still choppy on the sansa but better than before.

petur commented on 2007-07-13 17:18

/me wonders why this isn’t making it into svn…

deathdr0ne commented on 2007-07-13 21:33

will test on ipod 64mb “60GB” model, and get back to you.

tdtooke commented on 2007-07-20 23:16

I’ve tested this on my iPod 30g 5.5g and I’m not sure if it has improved the sound, but it’s still definitely worse than before they commited that rockboy sound change recently. I’m toying with the idea of taking this patch and merging it with another that basically throws alotta ifdefs in so some of the changes recently committed are undone if the target is an iPod. I’m quite some ways from actually being able to do that, since that would involve tracking down exactly what change killed the sound on the iPod, but it’s a thought.

kkurbjun commented on 2007-07-21 02:27

Here is a newer version of the patch, this is an almost complete rewrite of the sound core based on visualboy advance.

   rocksound.diff (29.4 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing