- Status Closed
- Percent Complete
- Task Type Patches
- Category Games
-
Assigned To
kkurbjun - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
-
Votes
1
- mcuelenaere (2007-07-14)
- Private
FS#7379 - Rockboy sound patch
This is a patch for rockboy that attempts to clean up the sound by adding in sound code from VisualBoy. If you test this please let me know the results including the player used and the game played.
Closed by kkurbjun
2007-07-21 04:04
Reason for closing: Accepted
Additional comments about closing:
2007-07-21 04:04
Reason for closing: Accepted
Additional comments about closing:
Patch committed to SVN - sound will be
different on players that cannot emulate
full speed (sound buffers are not
improperly repeated any more)
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Forgot the file
Plays excellent on my F40. Tremendous difference from the current one in SVN.
Choppy on H300 but that’s because it can’t get more than 50+ fps.
Still choppy on the sansa but better than before.
/me wonders why this isn’t making it into svn…
will test on ipod 64mb “60GB” model, and get back to you.
I’ve tested this on my iPod 30g 5.5g and I’m not sure if it has improved the sound, but it’s still definitely worse than before they commited that rockboy sound change recently. I’m toying with the idea of taking this patch and merging it with another that basically throws alotta ifdefs in so some of the changes recently committed are undone if the target is an iPod. I’m quite some ways from actually being able to do that, since that would involve tracking down exactly what change killed the sound on the iPod, but it’s a thought.
Here is a newer version of the patch, this is an almost complete rewrite of the sound core based on visualboy advance.