Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 3
  • Private
Attached to Project: Rockbox
Opened by John Zhou - 2007-07-15
Last edited by Jonathan Gordon - 2007-07-31

FS#7437 - New menu item to delete the current playing file. Tested on SANSA, should work for all players.

Hey guys, and gals who are brave enough,

Here is a very easy patch that allows you to delete the current playing music file via the WPS menu (only changed one line of code in onplay.c).

I tested it on my Sansa e280 player only, but it should work on all players as it’s just one line of code change on the latest build.

I’m aware that there is already a similar patch (ID 4812) made a while ago, but it didn’t work on the latest Rockbox build. The code was completely outdated.

—— Reason for this Patch ——

I started using Rockbox for my Sansa e280 player a week ago, hoping it could allow me total control of all the files stored on the player just like a computer.

Everything is just perfect, except to my disappointment Rockbox still doesn’t allow me to delete the currently playing music files via the WPS menu.

I just need this feature in order to organize my musics more efficiently because I listen to a lot of new music. This will allow me to just upload all the new music files onto the player, listen to them, and easily delete the unwanted ones.

I’m now 100% happy with Rockbox! Thanks to the team for making this wonderful Open Source firmware so that even newbies like me can contribute.

—— Known Issues ——

There is just one small issue with this patch, but I consider it a feature, not really a bug.

After the current playing file is deleted it will continue to play, probably from the memory buffer. You can allow it to finish or you can just press NEXT to skip it. I’m not going to bother adding more code to automatically skip to the next song because I’d like to give the poor song a last chance to be at least played fully once before it is wiped forever : D

BTW, for newbies:

1. In case you don’t know, you must compile your own Rockbox build in order to use this patch, and all other patches.
See details at : http://www.rockbox.org/twiki/bin/view/Main/SimpleGuideToCompiling

2. You must then
apply the patch before compiling the build again.
See details at :
http://www.rockbox.org/twiki/bin/view/Main/SimpleGuideToCompiling#Adding_Patches

Enjoy!

Closed by  Jonathan Gordon
2007-07-31 12:26
Reason for closing:  Accepted
Dominik Riebeling commented on 2007-07-15 21:59

This will definitely trigger a known bug – see the related task  FS#5642 .

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing