Rockbox

Tasklist

FS#7439 - rbutil theme installation always fails (for me on windows), fixes

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Sunday, 15 July 2007, 10:30 GMT
Last edited by Dominik Wenger (Domonoky) - Sunday, 15 July 2007, 17:44 GMT
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

On my system, rbutil can't install Themes correctly. I found and fixed three issues here:

1. checkZip always fails for me, and it looks like because IsDir is always false. Fixed to look at the subdir of the fullname rather than assume Dir entries exist in zipfile

2. if directory creation on device fails, rbutil hangs, because UnzipFile has a codepath that just returns in the middle of the function rather than cleaning up properly. fixed.

3. creation of subdirectories on device was not working for me, again because IsDir is always false for me. Fixed to always create the subdir of the given pathname, and also create the name itself if IsDir happens to be true (perhaps on other peoples' systems?)
This task depends upon

Closed by  Dominik Wenger (Domonoky)
Sunday, 15 July 2007, 17:44 GMT
Reason for closing:  Accepted
Comment by Dave Hooper (stripwax) - Sunday, 15 July 2007, 10:32 GMT
file
Comment by Dave Hooper (stripwax) - Sunday, 15 July 2007, 11:03 GMT
Fix

Loading...