Rockbox

Attached to Project: Rockbox
Opened by stripwax - 2007-07-15
Last edited by Domonoky - 2007-07-15

On my system, rbutil can’t install Themes correctly. I found and fixed three issues here:

1. checkZip always fails for me, and it looks like because IsDir is always false. Fixed to look at the subdir of the fullname rather than assume Dir entries exist in zipfile

2. if directory creation on device fails, rbutil hangs, because UnzipFile has a codepath that just returns in the middle of the function rather than cleaning up properly. fixed.

3. creation of subdirectories on device was not working for me, again because IsDir is always false for me. Fixed to always create the subdir of the given pathname, and also create the name itself if IsDir happens to be true (perhaps on other peoples’ systems?)