Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Operating System/Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Kévin Ferrare - 2007-07-20
Last edited by Peter D'Hoye - 2007-07-20

FS#7457 - Hiding dircache behind a posix API

Hi,

I made this patch with which presents dircache (and normal dir api for targets without it) as a standard posix api.

This avoids confusion in app code, so that devs won’t mistake and use the dircache-disabled api when dircache is enabled, saving some disks spins

Closed by  Peter D'Hoye
2007-07-20 22:34
Reason for closing:  Accepted
Kévin Ferrare commented on 2007-07-20 09:48

forgot to add the dir.h file.
Patch and add that file to firmware/include

   dir.h (1.5 KiB)
Kévin Ferrare commented on 2007-07-20 16:15

Apply the patch, ignore the "File firmware/common/dir.c is not empty after patch, as expected" error and remove firmware/common/dir.c

works here

Michael Sevakis commented on 2007-07-20 19:04

I have never looked into the details of dircache and frankly I think it should work through the normal file APIs without any awareness by the caller of those APIs that it's even there or not. Is that the intent here? It's the impression I get from a quick scan of the patch.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing