Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Plugins
  • Assigned To No-one
  • Operating System iriver H10
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by AceNik - 2007-08-03
Last edited by rasher - 2008-12-11

FS#7528 - Superdom should yield during AI calculations

Hey guys the new superdom plugin is very nice, but , when i try playing the game with increasing the computers farms & factories to above normal level like suppose 2,2 & also have music playback in the background the H10[20GB] seems to have lot of hang ups, i dont know if this is true for other players if yes, please feel free to add in your comments

btw this is regarding rockbox build no. 14156

[admin edit: Title updated to better reflect the problem]

Closed by  rasher
2008-12-11 02:02
Reason for closing:  Fixed
Additional comments about closing:  

Patch that should fix this issue committed in r19389.

rasher commented on 2007-08-03 15:18

Looking at the code, Superdom doesn't yield a single time. This should probably be fixed and should hopefully let music playback continue.

Soul-Slayer commented on 2007-08-03 16:59

Patch that adds yielding. I can't be 100% sure it works as my H10 is a 6GB, so it's screen is too small to test. I tried it on my Gigabeat though and hasn't caused any freezes.

   superdomyield.diff (6.6 KiB)
aliask commented on 2007-08-04 13:08

I haven't got a DAP to test this patch on, but it takes Johnathon's idea and tweaks it a bit. If this fixes everything up then I'll commit, but I have no way to know until I can get some feedback.

   superyield.patch (7.2 KiB)
aliask commented on 2007-08-14 10:20

Hopefully a more accurate patch. I do need feedback on these though, as I have no way of telling if these work or not.

   superdom_yieldmore.patch (1.8 KiB)
jdgordon commented on 2008-11-28 03:17

Will, can this be commited?

aliask commented on 2008-11-28 03:40

Let me test it on my gigabeat, with and without patches and I'll see how it goes.

aliask commented on 2008-11-28 04:55

Played two whole games with music running in the background, no noticeable freezes without patch - perhaps someone with a lower powered target than the Gigabeat S should test this.

Project Manager
bagder commented on 2008-12-01 13:28

Well, I don't think the yields will introduce many problems but at least fix some so I think this should be committed rather than to wait for testers…

Unhelpful commented on 2008-12-11 01:57

Commit this. I agree with Daniel, we can't be sure this entirely fixes the problem, but it will likely help and is harmless.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing