• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by GRaTT - 2007-08-05
Last edited by jdgordon - 2011-07-20

FS#7542 - This patch moves all the playlist creation from theroot dir to the PLAYLISTS directory.

This patch moves all the playlist creation etc… from the
root dir to the PLAYLISTS directory.
root.m3u8 and dynamic.m3u8 will be created in /PLAYLISTS.
The playlist catalog already uses /PLAYLISTS as default.
The OF creates this dir by default so it is always there
might as well use it to clean up the root.

Closed by  jdgordon
2011-07-20 14:15
Reason for closing:  Out of Date

Seeing as you can copy and paste files, shouldn’t the playlist be created in the folder that you created it in, rather than placing it in an arbitrary folder that may not even exist?

And not every player’s OF creates the folder. Rockbox needs to, on an application level, act functionally similar on all players.

GRaTT commented on 2007-08-06 04:32

The database uses /Playlists/ by default.
But all of my playlists regardless are created in the root.
My preference is to have all my playlists in one location
and since the database default is /playlists and the Sansa
OF creates this I felt this made sense.

The Rockbox database doesn’t use playlists at all. What are you talking about? Do you mean the “Playlist Catalog” feature?

GRaTT commented on 2007-08-06 04:36

Yes I mean the catalog feature.

It is a very good idea, as I would also like all my playlists in the one directory. If putting playlists in /PLAYLISTS/ is not within guidelines maybe it could at least be an option which is disabled by default? Also why is there no download available for download this patch?

GRaTT commented on 2007-08-06 18:16

here is the patch.

Why does it only enable for the Sansa?

GRaTT commented on 2007-08-07 13:19

I know for sure the sansa has the “Playlists” folder by default. The patch is small enough
that if you want to enable it for your player
just edit the #ifdef SANSA_E200.

it only has it if you go into the OF

Making it make the folder when built if it doesn’t already exist would be logical.

vmh commented on 2007-08-07 19:14

- check if folder ‘Playlists’ already exists
- merge with playlist_catalog

GRaTT commented on 2007-08-08 05:04

Thanks vmh.
@jdgordon: once rockbox has usb for PP targets then sansa owners will be free.
But I understand what you are saying. “If” this will get into svn then it
must address all targets. From previous forum posts and the first comment to this
patch I did not think this was wanted behavior. However I think this patch
makes the Playlist Catalog and playlists in general more user friendly,
and now thanks to vmh it does address all targets.

vmh commented on 2007-08-08 06:52

simplify and comment the added function playlist_check_dir()

jac0b commented on 2008-02-02 01:33

Patch is out of sync with SVN

vmh commented on 2008-02-02 18:06

synchronized to r16201.
I don’t know if it still works correctly. I don’t have time to test it.

vmh commented on 2008-04-18 20:05

- synchronized to r17158
- simplified (using dir_exists()) and renamed playlist_check_dir to check_mkdir

Shouldn’t it obey the “playlist catalog directory” setting?

vmh commented on 2008-04-28 19:14
Shouldn’t it obey the “playlist catalog directory” setting?
You’re right.

- use global_settings.playlist_catalog_dir (maybe it should be renamed to ‘playlist_dir’, but I don’t want to make changes in too many files)
- remove some unnecessary codes in playlist_catalog.c

jayme commented on 2008-11-09 21:34

Resync to rev. 19053

jac0b commented on 2009-07-24 01:41

Opps the above patch is incorrect this one should work


Available keyboard shortcuts


Task Details

Task Editing