Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by ddalton - 2007-08-08
Last edited by rasher - 2007-08-21

FS#7561 - Say the time in 12 hour format

Voice the time in 12 hour format under the info screen. It even says a m and pm. In english.lang I had to write a m so it wouldn't say am. Anyway here it is.

Closed by  rasher
2007-08-21 22:55
Reason for closing:  Accepted
Additional comments about closing:  

Committed in r14418. Thanks.

just a bit of an update.

allows the time to be voiced in 12 or 24 hour. Just change the setting in /settings/general settings/system/time/time format to how you want it to be displayed and voiced.

A couple of things:
Removed the ability to voice the secconds. This is very easy to add again so let me know if you want it added. I couldn't see how you would say the time in 12 hour format with secconds. Would you like it to say seven forty four and seven seconds pm? or "seven forty four pm and seven secconds" so let me know. I removed it from the 24 hour clock as well.
This only effects the voice.

Also the indentation is wrong. I am looking into linux and a better text editor. so If you want you can fix the indentation. Anyway here it is.

I fixed the indenting here.

Just cleaned up the code a bit. So it is easier to read and not as long. Also I haven't tested it but it should work. If it doesn't I will post an update tomorrow. Also noone has said anything about the seconds being removed so I think I will just keep it this way. I don't really have a need to here the settings.

Here it is…

I fixed up the patch. It didn't work before. So just made some small changes.
Also in my last comment I meant I don't have a need to here the seconds voiced.

Anyway here it is again. Sorry about the confusion.

Just cleaned up the code a bit.
Removed a comment and used and else instead of another if.

Here it is…

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing