FS#7563 - Speak dynamic equalizer setting menus

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Thursday, 09 August 2007, 01:48 GMT
Last edited by Steve Bavin (pondlife) - Tuesday, 09 October 2007, 07:41 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Dynamic menus use a callback function to provide the text of each menu
item. That's how the "Simple EQ Settings" menu is able to display a
configurable frequency in a menu item name, and it's also used in the
"Advanced EQ Settings" menu to avoid repetitive lang entries for Peak
Filter 1, 2 and 3. Those menu items are not spoken however.

What I did is simply to add a voice callback to dynamic menus, along side
the text_callback. The voice_callback goes ahead and speaks the item,
rather than returning lang IDs. It's called from the talk_menu_item()
function that speaks constant items.

And I implemented such callbacks for the two eq menus, of course.

The menu system macros are a bit painful to follow, but my modifications
are straightforward.
This task depends upon

Closed by  Steve Bavin (pondlife)
Tuesday, 09 October 2007, 07:41 GMT
Reason for closing:  Accepted
Additional comments about closing:  Speak to Bagder or Zagor on IRC... :)
Comment by Sofian Babai (sofianbabai) - Thursday, 27 September 2007, 17:26 GMT
interesting patch. don't know why it hasn't been implmented since the other sounds settings are voiced.