• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by sdoyon - 2007-08-09
Last edited by pondlife - 2007-10-09

FS#7563 - Speak dynamic equalizer setting menus

Dynamic menus use a callback function to provide the text of each menu
item. That’s how the “Simple EQ Settings” menu is able to display a
configurable frequency in a menu item name, and it’s also used in the
“Advanced EQ Settings” menu to avoid repetitive lang entries for Peak
Filter 1, 2 and 3. Those menu items are not spoken however.

What I did is simply to add a voice callback to dynamic menus, along side
the text_callback. The voice_callback goes ahead and speaks the item,
rather than returning lang IDs. It’s called from the talk_menu_item()
function that speaks constant items.

And I implemented such callbacks for the two eq menus, of course.

The menu system macros are a bit painful to follow, but my modifications
are straightforward.

Closed by  pondlife
2007-10-09 07:41
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Speak to Bagder or Zagor on IRC… :)

interesting patch. don’t know why it hasn’t been implmented since the other sounds settings are voiced.


Available keyboard shortcuts


Task Details

Task Editing