- Status Closed
- Percent Complete
- Task Type Patches
- Category Drivers
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
-
Votes
2
- Timo Horstschäfer (2007-08-26)
- Jeton Aliji (2007-08-18)
- Private
Attached to Project: Rockbox
Opened by Timo Horstschäfer - 2007-08-12
Last edited by Frank Gevaerts - 2011-06-04
Opened by Timo Horstschäfer - 2007-08-12
Last edited by Frank Gevaerts - 2011-06-04
FS#7588 - ata_wakeup()
The ata_wakeup() function does the opposite of ata_sleep(), it spins up the hard-disk in background.
This makes it possible to start the disk in advance to reduce access time later.
It also eliminates some duplicate code lines in ata.c.
ata_wakeup.patch
(5.5 KiB)
I like the idea, especially as I thought this existed already and I’m going to need it soon :)
One remark, though: don’t add functions to the plugin API in the middle of the struct, it breaks binary compatibility. You should add them at the end. FYI, when the struct is reordered, the plugin API version needs to be bumped.
this will break the ondio and sansas… you need to add a ata_wakeup() stub in firmware/drivers/ata-mmc.c and firmware/target/arm/sandisk/sansa-e200/ata-e200.c
Stubs added and moved ata_wakeup() to the end of the plugin API.
The patch doesn’t apply with build 2008-03-01 (r16460).
Is it possible to sync it?
TYA
Rosso: DO NOT ASK FOR RESYNCS
Why I have not to do it? Is there something like an etiquette I didn’t read?
If the patch is no more useful because it was included in the main trunk or it became “obsolete”, should it mark as closed?
Thanks for the attention.
it annoys developers. i the patch was commited then yes this would be closed, but it isnt so it isnt
resync
I hope this works…