Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by huwsy - 2003-01-15
Last edited by huwsy - 2003-06-06

FS#761 - One (On) button hold

These diff files are not in the standard formating, as I am
unsure what options I need to pass to diff to get the
conventional formating. But they should still work.
These diffs have been made against csv build of the files
dated 14th Jan 03.

Tempo Accellerator:

When chainging the tempo, the longer the key is pressed
down for the larger the steps the tempo changes with.

File filter from F2 to F3:

The file filter option ( all/supported/music ) has been
moved from F2 to F3 so that it is with more similar
functions.

Mute from F1 combo to F2:

Mute has been placed under F2 instead of being F1 and
play.

Hold from F1 combo to On:

Pressing the On button for a few seconds activates the
keylock/hold function.

Volume not locked:

When the keys are locked it is possible to change the
volume.

unconventional diff file

is newer/modified data

< is older/removed data

Closed by  zagor
2003-06-04 12:24
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Logged In: YES
user_id=1157

This is a general UI change. Please discuss this on the
mailing list. There is a plan for this already.

Anonymous Submitter commented on 2003-01-15 23:29

Hi. I love this patch! I perosnally dont know how to compile
code, etc… Is it possible for you to post the .ajbrec file here,
so many people can enjoy your hard work?

Thakns alot!!!

Anonymous Submitter commented on 2003-01-16 18:51

I have to agree with the concept that you have tried with these
patches. Many of the original rockbox button arrangements
have seemed muddled, and (to me anyway) this makes more
sense. Maybe someone will realise this.

Only one question… I assume the "Tempo Change" (Pitch
Adjust?) has to be activated quickly, before the Keypad
locks??? That would make sense, but just checking.

huwsy commented on 2003-01-18 11:42

The tempo function has been moved to F1, to prevent such a
problem.

in addition to the diff files in the file below tree.c needs
modifying. Line 1174

< case TREE_MENU:

case TREE_MENU | BUTTON_REL:
huwsy commented on 2003-01-19 16:08
Warning: Undefined array key "sepchar" in /home/rockbox/flyspray/plugins/dokuwiki/inc/pageutils.php on line 84 Warning: Undefined array key "useslash" in /home/rockbox/flyspray/plugins/dokuwiki/inc/pageutils.php on line 93 Unhandled exception: strtr(): Argument #2 ($from) must be of type array, string given
This should never happen, please inform Flyspray Developers.

If you are an Administrator of this Flyspray installation you might enable temporarly! DEBUG_EXCEPTION in constants.inc.php for more details.