FS#761 - One (On) button hold

Attached to Project: Rockbox
Opened by Huw Smith (huwsy) - Wednesday, 15 January 2003, 21:21 GMT
Last edited by Huw Smith (huwsy) - Friday, 06 June 2003, 18:43 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


These diff files are not in the standard formating, as I am
unsure what options I need to pass to diff to get the
conventional formating. But they should still work.
These diffs have been made against csv build of the files
dated 14th Jan 03.

Tempo Accellerator:

When chainging the tempo, the longer the key is pressed
down for the larger the steps the tempo changes with.

File filter from F2 to F3:

The file filter option ( all/supported/music ) has been
moved from F2 to F3 so that it is with more similar

Mute from F1 combo to F2:

Mute has been placed under F2 instead of being F1 and

Hold from F1 combo to On:

Pressing the On button for a few seconds activates the
keylock/hold function.

Volume not locked:

When the keys are locked it is possible to change the

unconventional diff file

> is newer/modified data

< is older/removed data
This task depends upon

Closed by  Björn Stenberg (zagor)
Wednesday, 04 June 2003, 12:24 GMT
Reason for closing:  Rejected
Additional comments about closing:  Logged In: YES

This is a general UI change. Please discuss this on the
mailing list. There is a plan for this already.
Comment by Anonymous Submitter - Wednesday, 15 January 2003, 23:29 GMT

Hi. I love this patch! I perosnally dont know how to compile
code, etc... Is it possible for you to post the .ajbrec file here,
so many people can enjoy your hard work?

Thakns alot!!!
Comment by Anonymous Submitter - Thursday, 16 January 2003, 18:51 GMT

I have to agree with the concept that you have tried with these
patches. Many of the original rockbox button arrangements
have seemed muddled, and (to me anyway) this makes more
sense. Maybe someone will realise this.

Only one question... I assume the "Tempo Change" (Pitch
Adjust?) has to be activated quickly, before the Keypad
locks??? That would make sense, but just checking.
Comment by Huw Smith (huwsy) - Saturday, 18 January 2003, 11:42 GMT

The tempo function has been moved to F1, to prevent such a

in addition to the diff files in the file below tree.c needs
modifying. Line 1174

< case TREE_MENU:

Comment by Huw Smith (huwsy) - Sunday, 19 January 2003, 16:08 GMT

Iv uploaded a newer version as I have noticed I missed a few
files out in the previous upload, and some of the code was not
there. This new version should be more understandable and
adaptable, these diffs are of the std format to allow easier
addition of the code. They are created against the daily build
of code dated 18th of January 2003. Also included is a pre
compiled version just to see it in action, for those of you who
cant or wont compile the code yourselfs.

To Rockbox developers: Im afraid some of this does not comply
to your CONTRIBUTING document as some of the lines of code
are over 80 char long but it made it much easier for me to
understand and to modify.


HuwSy -
Comment by Huw Smith (huwsy) - Wednesday, 22 January 2003, 21:38 GMT

Now when you mute, the mute icon will apear in status. and
chainging the volume will unmute and continue from where it
was. Now all in one diff file.
Comment by Björn Stenberg (zagor) - Tuesday, 28 January 2003, 12:47 GMT

UI changes like this should be discussed on the mailing list.
Comment by Anonymous Submitter - Saturday, 01 March 2003, 17:11 GMT


Date: 2003-01-28 04:47

Sender: zagor

Logged In: YES

UI changes like this should be discussed on the mailing list.

How? How do i make these discuss these on the "mailing list,"

Comment by Huw Smith (huwsy) - Monday, 14 April 2003, 17:38 GMT

New version based upon newer code (12 April) And requireing
fewer changes. Swaps Hold with Pitch only. So press and
hold ON to lock the keys
Comment by Björn Stenberg (zagor) - Wednesday, 04 June 2003, 12:24 GMT

This is a general UI change. Please discuss this on the
mailing list. There is a plan for this already.
Comment by Huw Smith (huwsy) - Friday, 06 June 2003, 18:43 GMT

v6 less changes needed. easier to apply.