FS#7622 - Some dB settings incorrectly voiced.

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Sunday, 19 August 2007, 09:11 GMT
Last edited by Nils Wallménius (nls) - Saturday, 19 April 2008, 13:19 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Voicing of some dB settings, like replay gain pre-amp advanced equalizer, crossfeed etc are voiced as db*10 so 2.5dB is voiced as 25dB etc.

The cause of this is that the internal representation of these values is dB*10 and this value is passed straight on to talk_value(); while the displayed value is first passed to a formatter function (see settings_list.c)

I wrestled a bit with the settings code but gave up in making this work in a clean way, I think that the voiced value should be passed through a formatter function as well.
This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 19 April 2008, 13:19 GMT
Reason for closing:  Fixed
Comment by Kenjiro Arai (MoonWolf) - Saturday, 29 March 2008, 10:10 GMT
Minus of Equalizer-Precut is pronounced by plus.