- Status Closed
- Percent Complete
- Task Type Patches
- Category Playlists
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#7626 - fixing problem with "End of Song List" when viewing playlist without playback
Currently when you do contextmenu - playlist - view, the playlist will open but closes immediately if you are not playing anything (play/pause) with error/info message “End of Song List”.
This turns out to be a bug in playlist_viewer.c, where a function that accepts an external filepath to open playlist checks for playing state, and if not playing/paused, exit and closes the playlist immediately.
I removed the part that checks for playing state since it’s not actually needed except for one small later check.
This should fix FS#7413 .
I tested it with my ipod 60GB, but no reason why it should not work on other targets as well. Comment below if you find anything wrong/no working as expected.
fix_view_playlist_when_not_pl...
(0.7 KiB)
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
How do you access context menu - playlist - view if your are not in play or pause mode? On my iPod I can access this menu item only from the WPS screen which only available in play or pause mode. The context menu which can be accessed be pressing long SELECT on a file in the file browser or in the database view shows only the entries "playlist - insert" and "playlist - insert shuffled" when in stop modus but no "playlist - view" entry.
When I select the "playlist" menu from the main menu there is a menu entry "View Current Playlist" but this works.
Sorry, not clear enough. If you do context menu on a *playlist* in file browser, the problem occurs.
Fixed a small display bug. Now it should not display a now playing icon next to the last song in playlist if the playlist has finished playing.
hmmm I created a playlist, used the context menu on it and viewed the playlist - while no music was playing.
iriver H10 and h300.
From file browser? i.e. do context-menu on .m3u or .m3u8 files? And playback state is stopped, not paused? Does not work for me… and the code, if I understand correctly, check for global resume state, and if stopped ( = -1 ) exit the while loop (thus the viewer screen) immediately and does not wait for any button to be pressed.
ok, so this only happens if playback can't be resumes. Reproduced and confirmed
patch looks likes it fixes it.
I'll need your full name to accept the patch