Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Settings
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by bascule - 2007-08-20
Last edited by bascule - 2007-11-20

FS#7628 - Non-intuitive keypress behaviour when setting song rating

When setting a rating for a song using the WPS context menu, the behaviour is as follows:

LEFT keypress - no action
RIGHT kepress - increment rating by one (which wraps to zero above 10)

Intuitively, LEFT should exit the context menu as per all other context menu entries.

Alternatively, it should decrement the rating by one.

I see no reason why LEFT should not exit the menu, given that it currently does nothing.

If it decremented the value, then it could be confusing for some users to have to navigate up or down in the menu list to then use LEFT to exit the menu.

This is on a Gigabeat, but AFAIK applies to all targets.

Closed by  bascule
2007-11-20 21:45
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407 Warning: Undefined array key "useheading" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 1099 Warning: Undefined array key "target" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557 Warning: Trying to access array offset on value of type null in /home/rockbox/flyspray/plugins/dokuwiki/inc/parser/xhtml.php on line 557

Now fixed in SVN:
http://svn.rockbox.org/vi ewvc.cgi?view=rev&revision=15529

I agree, LEFT should exit.

It used to, maybe the function got lost in the transition to the new menu api. Maybe it is worth considering using the standard setting api for it (select from a list of values)?

Yes, consistency is good.

nls commented on 2007-08-21 13:21

+1 for the list suggestion

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing