FS#7628 - Non-intuitive keypress behaviour when setting song rating
Attached to Project:
Rockbox
Opened by Eddy (bascule) - Monday, 20 August 2007, 14:21 GMT
Last edited by Eddy (bascule) - Tuesday, 20 November 2007, 21:45 GMT
Opened by Eddy (bascule) - Monday, 20 August 2007, 14:21 GMT
Last edited by Eddy (bascule) - Tuesday, 20 November 2007, 21:45 GMT
|
DetailsWhen setting a rating for a song using the WPS context menu, the behaviour is as follows:
LEFT keypress - no action RIGHT kepress - increment rating by one (which wraps to zero above 10) Intuitively, LEFT should exit the context menu as per all other context menu entries. Alternatively, it should decrement the rating by one. I see no reason why LEFT should not exit the menu, given that it currently does nothing. If it decremented the value, then it could be confusing for some users to have to navigate up or down in the menu list to then use LEFT to exit the menu. This is on a Gigabeat, but AFAIK applies to all targets. |
This task depends upon
Closed by Eddy (bascule)
Tuesday, 20 November 2007, 21:45 GMT
Reason for closing: Fixed
Additional comments about closing: Now fixed in SVN:
http://svn.rockbox.org/viewvc.cgi?view=r ev&revision=15529
Tuesday, 20 November 2007, 21:45 GMT
Reason for closing: Fixed
Additional comments about closing: Now fixed in SVN:
http://svn.rockbox.org/viewvc.cgi?view=r ev&revision=15529

I agree, LEFT should exit.

It used to, maybe the function got lost in the transition to the new menu api. Maybe it is worth considering using the standard setting api for it (select from a list of values)?

Yes, consistency is good.

+1 for the list suggestion