- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by ddalton - 2007-08-22
Last edited by linusnielsen - 2007-08-23
Opened by ddalton - 2007-08-22
Last edited by linusnielsen - 2007-08-23
FS#7641 - Change voicing of time.
This patch makes the 24 hour time spoken as:
"14 hundred hours"
and it also will say "14 07"
If it is set to 12 hour format it will say
"7 o'clock a m" And it will say "7 07 a m" as well.
I know everyone has there own opinion on how the time should be voiced. So I don't expect this to get commited. Anyway it is here anyway.
I haven't tested it but it compiles and it should work. Let me know if it doesn't.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
I've not tested it, but looking at the code I suspect that 14:20 would be voiced as "fourteen oh twenty". Shouldn't the "oh" only be included if minutes < 10?
I think you are right I will submit an update in the next few minutes.
Also how should 9 o'clock in the morning be voiced?
9 hundred hours? or 9 o'clock
Thanks
Ok here is the update. Only voice oh if the minute is < 10. Otherwise just say the value of the minute.
I haven't tested this but I will and if I find a problem I will post an update.
9 in the morning should be 9 o'clock in 12 hour, or 9 hundred hours in 24 hour (going with the system you're using).
So you mean "9 hundred hours"?
Anyway this doesn't compile so I will have to fix it. I think I know how this can be simplified as well.
No - I meant "9 bundred hours" Just at 9am, you understand.
Sorry - it's early here and my fingers haven't woken up yet…
The time_fix2.patch file was missing a brace. Here is a corrected version, with indentation fixes as well.
Seems to work fine.