Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rasher - 2007-08-22
Last edited by rasher - 2007-08-25

FS#7646 - Perl voicebuilding

This is the first attempt to port the current voice scripts to perl. The benefits are/should be numerous:
- Should give a huge speedup on Cygwin
- Also gives a nice speedup in Linux & relatives.
- Should allow better use of SAPI (it might be possible to keep a single connection open)
- Perl, as horrible as it is, is probably more hacker-friendly than shell for large jobs, and should hopefully allow more people to help out.
- The configure script looks slightly nicer. And voice building is better integrated.
- voice.pl is a single file and can be run directly from the commandline. In theory all that’s needed is voicefont, genlang, english.lang and the appropriate language-file.

There are still some caveats though:
- The reason for this re-implementation was to allow TTS tweaks (phonetical replacements) - I have not added this yet.
- The script should eventually allow .talk clip generation as well. This is not yet implemented.

Given how much brouhaha the last voice change generated, I wonder if this should get a mention on either of the mailing lists? Thoughts?

   perl-voice-building.diff (12.2 KiB)
Closed by  rasher
2007-08-25 22:15
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Commmitted in r14457

rasher commented on 2007-08-22 22:03

I also forgot, probably most importantly:
- SAPI5 building isn’t implemented yet. This should definitely be done before even considering committing this. If someone with a clue about Windows/SAPI5 could do this, I’d very much appreciate it.

rasher commented on 2007-08-24 12:50

Updated patch that adds the following:
- Responds to V=1 being set (call “V=1 make voice” to see details during build)
- Shows a bit of information about what’s being built
- Shows progress indicator
- An attempt at SAPI5 building (still just calls the .vbs over and over - someone could probably improve this)

Please test and report back - especially SAPI5 voice building.

rasher commented on 2007-08-24 12:51

And I of course forgot the file.

   perl-voice-building-v2.diff (13 KiB)
rasher commented on 2007-08-24 14:51

Update:
- Add sapi5_voice_new.vbs - accepts alternating lines of string and filename on stdin and voices the string into filenames. Exits when filename is blank.
- Use this script for SAPI5 building - this greatly speeds up voicefile generation in Cygwin (launching LAME many times still takes time, but there’s probably not much that can be done about that).

   perl-voice-building-v3.diff (16 KiB)
GodEater commented on 2007-08-24 15:49

Works fine on linux here (Gentoo if it matters). Got about a 20 second speed increase too.

rasher commented on 2007-08-24 23:44

Update:
- Add possibility to do regexp search&replace on strings
- Special handling of VOICE_PAUSE (this file is added to the tools/ dir
- Add wavtrim step
- Fix tools/Makefile to remove voicefont and wavtrim when running make clean (not related, to be honest)
- Save the voicefile to a different filename instead of overwriting an existing voicefile of the same name

I created a section on the VoiceBuilding wikipage for keeping track of this patch.

   perl-voice-building-fs7646-v4... (19.1 KiB)
   voice_pause.wav (26 KiB)
rasher commented on 2007-08-25 12:20

Two tiny (but somewhat important changes)
- Fix the call to voicefont to properly include the target id
- Change the default lame settings to include -B 64 and –vbr-new

   voice_pause.wav (26 KiB)
   perl-voice-building-fs7646-v5... (19.2 KiB)
rasher commented on 2007-08-25 21:51

This should be my final version. Changes in this version:
- Building of multiple voices disabled (it wasn’t implemented properly, so I’ll have a go at it after this has been committed)
- The voice script now cleans up after itself if interrupted
- Changing of default options for festival based on which language is selected, the same could easily be done for other engines.

   perl-voice-building-fs7646-v6... (20.7 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing