FS#766 - Autobookmarks (multiresume) and Bookmarking

Attached to Project: Rockbox
Opened by Anonymous Submitter - Thursday, 16 January 2003, 19:49 GMT
Last edited by Björn Stenberg (zagor) - Monday, 27 January 2003, 15:47 GMT
Task Type Patches
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


If you have any questions/suggestions, contact me at The diff file was
generated off of rockbox-daily-20030116.

Autobookmarking (Multi File Resume)
This patch creates the ability to autobookmark a file
when stopping that file with the OFF button. The code
takes the existing resume information and stores that to
a file based off of the file name (foo.mp3 creates a file
called foo.mp3.resume). Each time an MP3/M3U is
played, the code will check for the the existence of the
above file and, if found, will prompt the user to load the

This patch has the preliminary bookmarking capability.
It can make a bookmark file with multiple bookmarks,
but will only load the first bookmark in the file. This will
be addressed in the next release of the patch (once I
figure out how to do menus!).

Know Issues/TBDs
1. For some reason, bookmarks will occasionally fail to

2. Need to create a menu when selecting a bookmark
file what will let the user choose which bookmark within
that file they want to play. Currently this loads the first
bookmark in the bmark file.

3. Manual bookmarks work, but only for MP3s. For
some reason, if attempting to bookmark a playlist, the
bookmark is created correctly, but the RockBox starts
playing at the last resume point.

4. Develop own better play capability.
I have duplicated the code for play_resume()
without the ask_resume() calls. Again, this is not the
best way to do this, but my knowledge of how to
actually play is lacking, so I haven't developed a more
robust method

5. Need to use the language files.
I've tried to use #define as much as possible, so it
should be trivial to use the LANG files.

6. Bookmark files are created, but they don't show up
until the next time the directory is loaded.

7. Need to come up with an icon for bookmark and
resume files

8. Need to store the autobookmark settings. They will
be restored to the defaults each time the RockBox is
turned on.
This task depends upon

Closed by  Björn Stenberg (zagor)
Monday, 27 January 2003, 15:47 GMT
Reason for closing:  Duplicate
Comment by Eric Linenberg (elinenbe) - Thursday, 16 January 2003, 19:54 GMT

Sounds like a great patch that will hopefully be part of the
main tree someday. I look forward to the next version. Good