Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Anonymous Submitter - 2003-01-16
Last edited by Björn Stenberg - 2003-01-27

FS#766 - Autobookmarks (multiresume) and Bookmarking

If you have any questions/suggestions, contact me at
rockbox_dev@samuraipanda.com. The diff file was
generated off of rockbox-daily-20030116.

Autobookmarking (Multi File Resume)


This patch creates the ability to autobookmark a file
when stopping that file with the OFF button. The code
takes the existing resume information and stores that to
a file based off of the file name (foo.mp3 creates a file
called foo.mp3.resume). Each time an MP3/M3U is
played, the code will check for the the existence of the
above file and, if found, will prompt the user to load the
bookmark.

Bookmarking.


This patch has the preliminary bookmarking capability.
It can make a bookmark file with multiple bookmarks,
but will only load the first bookmark in the file. This will
be addressed in the next release of the patch (once I
figure out how to do menus!).

Know Issues/TBDs


1. For some reason, bookmarks will occasionally fail to 

load.

       
2. Need to create a menu when selecting a bookmark 

file what will let the user choose which bookmark within
that file they want to play. Currently this loads the first
bookmark in the bmark file.

3. Manual bookmarks work, but only for MP3s.  For 

some reason, if attempting to bookmark a playlist, the
bookmark is created correctly, but the RockBox starts
playing at the last resume point.

4. Develop own better play capability.  
   FIX NOTE: 
      I have duplicated the code for play_resume() 

without the ask_resume() calls. Again, this is not the
best way to do this, but my knowledge of how to
actually play is lacking, so I haven’t developed a more
robust method

5. Need to use the language files.
   FIX NOTE: 
      I've tried to use #define as much as possible, so it 

should be trivial to use the LANG files.

6. Bookmark files are created, but they don't show up 

until the next time the directory is loaded.

7. Need to come up with an icon for bookmark and 

resume files

8. Need to store the autobookmark settings.  They will 

be restored to the defaults each time the RockBox is
turned on.

Closed by  Björn Stenberg
2003-01-27 15:47
Reason for closing:  Duplicate
Eric Linenberg commented on 2003-01-16 19:54

Sounds like a great patch that will hopefully be part of the
main tree someday. I look forward to the next version. Good
luck.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing