FS#7661 - Make ID3 info screen more readable

Attached to Project: Rockbox
Opened by Xinlu Huang (polygonal) - Sunday, 26 August 2007, 16:34 GMT
Last edited by Paul Louden (Llorean) - Tuesday, 25 March 2008, 17:29 GMT
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No


It's a very small UI tweak. The current ID3 info screen in WPS context menu crowds information in two line blocks, which is quite hard to read, especially when line selector is not inverse bar. I add a third line and make the list selects three-line blocks. I don't know if the current ID3 screen is voiced or if I break anything voicing in that screen. I wrote this patch for myself and hope it might be helpful for people who read the ID3 screen a lots.
This task depends upon

Closed by  Paul Louden (Llorean)
Tuesday, 25 March 2008, 17:29 GMT
Reason for closing:  Rejected
Additional comments about closing:  Customizable font size makes this pretty much irrelevant.
Comment by Jake Melvin (Monkeytamer) - Sunday, 26 August 2007, 18:04 GMT
I like this addition to the id3 screen, as it makes everything a lot more readable. I actually make use of the id3 screen, since the WPS I use has large album art, and so to view more details about the file I must go to the id3 screen. Thanks for sharing this useful patch!
Comment by Thomas Martitz (kugel.) - Monday, 01 October 2007, 15:09 GMT
How about committing this one?
Comment by Dominik Riebeling (bluebrother) - Monday, 01 October 2007, 17:12 GMT
I like it much better the way it currently is -- on smaller screens adding an empty line is pure waste, and when using the bar selector it's really useable.
Comment by Thomas Martitz (kugel.) - Monday, 01 October 2007, 17:27 GMT
I understand that. But why not committing it only for targets with specific screen size and higher. It's really bad to read on an (f.e.) e200.

Unreadable with bar selector? What do you mean? I have no problems with reading it with a bar selector.
Comment by Dominik Riebeling (bluebrother) - Monday, 01 October 2007, 18:02 GMT
It seems you got my comment wrong: it's definiteably *useable* using the bar selector.

And I'm against committing it for some targets only -- Rockbox looks the same on all targets (well, depending on target capabilities of course) and I don't think we should break with that. And why is it bad to read on a target with larger screen?
Comment by Xinlu Huang (polygonal) - Monday, 01 October 2007, 21:43 GMT
I understand the argument with Rockbox looking the same on targets, but it is really hard to read the ID3 viewer on larger screen unless you use a huge font (I mean like > 36pt), which essentially make a large screen working like a small one. Otherwise the information is squashed together and your eyes are just lost in those characters on screen. The inverse bar (or the gradient bar now ;) only make it barely above unreadable. Putting the empty lines is on the same principle as you put an empty lines (at least in some format requirement) between paragraphs: it makes you quickly focus on what you want to see rather than have your eyes wander around.