Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To
    Björn Stenberg
  • Operating System
  • Severity Medium
  • Priority Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Benjamin Metzler - 2003-01-16
Last edited by Björn Stenberg - 2004-01-14

FS#769 - Autobookmarks (multiresume) and Bookmarking, with diff

This time, with the diff.

Autobookmarks (multiresume) and Bookmarking
If you have any questions/suggestions, contact me at
rockbox_dev@samuraipanda.com. The diff file was
generated off of rockbox-daily-20030116.

Autobookmarking (Multi File Resume)


This patch creates the ability to autobookmark a file
when stopping that file with the OFF button. The code
takes the existing resume information and stores that to
a file based off of the file name (foo.mp3 creates a file
called foo.mp3.resume). Each time an MP3/M3U is
played, the code will check for the the existence of the
above file and, if found, will prompt the user to load the
bookmark.

Bookmarking.


This patch has the preliminary bookmarking capability.
It can make a bookmark file with multiple bookmarks,
but will only load the first bookmark in the file. This
will
be addressed in the next release of the patch (once I
figure out how to do menus!).

Know Issues/TBDs


1. For some reason, bookmarks will occasionally fail to
load.

2. Need to create a menu when selecting a bookmark
file what will let the user choose which bookmark within
that file they want to play. Currently this loads the first
bookmark in the bmark file.

3. Manual bookmarks work, but only for MP3s. For
some reason, if attempting to bookmark a playlist, the
bookmark is created correctly, but the RockBox starts
playing at the last resume point.

4. Develop own better play capability.
FIX NOTE:
I have duplicated the code for play_resume()
without the ask_resume() calls. Again, this is not the
best way to do this, but my knowledge of how to
actually play is lacking, so I haven’t developed a more
robust method

5. Need to use the language files.
FIX NOTE:
I’ve tried to use #define as much as possible, so it
should be trivial to use the LANG files.

6. Bookmark files are created, but they don’t show up
until the next time the directory is loaded.

7. Need to come up with an icon for bookmark and
resume files

8. Need to store the autobookmark settings. They will
be restored to the defaults each time the RockBox is
turned on.

Closed by  Björn Stenberg
2004-01-14 08:04
Reason for closing:  Accepted
Additional comments about closing:  

Logged In: YES
user_id=1157

Committed.

Anonymous Submitter commented on 2003-01-18 21:13

WOW, seems like an awesome patch!! benjamintm, could
you please compile it for us non-programmers, so we could
also use this wonderful feature?

Thanks alot!!

Benjamin Metzler commented on 2003-01-19 23:51

I’ll be posting a link to a compiled version next week…Ben

Anonymous Submitter commented on 2003-01-20 03:35

Thank you very, very much!!!

Benjamin Metzler commented on 2003-01-21 17:43

I have posted a compiled version
at:http://www.samuraipanda.com/bookmarks.zip.

- Ben

Anonymous Submitter commented on 2003-01-26 17:58

It may be just my imagination, but it seems that whenevre i
use this firmware, i hear the hard drive spinning alot mor
often, as aposed to the daily builds. It seems that every 4 or
5 seconds, the hard drive spins up, where as in the daily
builds, it seems like it takes 1 - 2minutes. Is this a bug, or is
it supposed to do that? also, will it ruin my Recorder?

Thanks

Benjamin Metzler commented on 2003-01-26 20:13

There was a bug in the first couple of releases where there
was more access to the hard disk then necessary. This was
fixed in the later releases. Download the latest version from
http://www.samuraipanda.com/bookmarks.zip. I’ve been
updating a lot recently so there are a bunch of
changes/additions/fixes. Again, this is patch and may have
bugs. They shouldn’t ruin your Recoder, but anything is
possible. If you are not comfortable with this, then stick with
the 1.4 release as that is supposed to be stable.

Anonymous Submitter commented on 2003-01-27 04:51

Ok, thank you very much, Myself, as well as many other
people commend your efforts, and appreciate immensely
what you are doing.

THANK YOU!!

Anonymous Submitter commented on 2003-01-27 17:50

This is absolutely a MUST HAVE feature! It’s working great for
me so far (using a AJBR15).
Who decides what features go into the next release? I want to
cast my vote for this!
I listen to Old Time Radio shows in the car to and from work,
and music during the day. I always had to hunt my place on
the show when I got back in the car… not any more!
Thanks, Benjamin

-Cameron
clidestri@yahoo.com

Benjamin Metzler commented on 2003-02-07 22:15

A new version has been posted. A compiled version can be
found at:
http://www.samuraipanda.com/bookmarks-20030207.zip - Ben

Benjamin Metzler commented on 2003-02-20 19:16

A new version has been posted. A compiled version can be
found at:
http://www.samuraipanda.com/bookmarks-20030220.zip - Ben

Benjamin Metzler commented on 2003-02-28 05:33

An unpdated compiled version can be found at:
www.samuraipanda.com/bookmarks-20030227.zip

Anonymous Submitter commented on 2003-03-04 05:00

Thanjks so much for updating regularily! All of us using
Rockbox apreciate you greatly!!

Thanks Again

Admin
Daniel Stenberg commented on 2003-03-04 16:11

A few comments on the 0227 version:

1. don’t memset() strings without reason all over
2. the comment about the bookmark format is wrong, as your
code uses “,” as separator while the comment says “*”. I
also think you should make the separator a proper define.

Another more minor issue is that the code rules say “less
than 80 columns” and you don’t. In my editor it makes your
long lines wrap weirdly.

Also, can you elaborate on what you mean with your “TBD” item 1 in the bookmark.c file?

Taken all into account, I think this patch is about to get
ready for inclusion.

Benjamin Metzler commented on 2003-03-17 07:05

Lot’s of changes have occured in the bookmarking code.
An unpdated compiled version and a list of changes can be
found at:
www.samuraipanda.com/bookmarks-20030316.zip

Anonymous Submitter commented on 2003-03-25 15:24

I would like to simply add a comment regarding the
importance of Rockbox firmware and Benjamin Metzler’s
patch for bookmarks. I have many digital audiobooks, some
of which are 18 hrs long per track. It is extremely important
to have a resume feature to return to the last read portion as
well as bookmarks. Bookmarks are especially important to
get to specific sections. For example, many of the
audiobooks have 15-20 stories spanning over 15 hrs, again,
all on one track! With bookmarks, I can easily navigate
through the books to get to my place in the audio file. I
sincerely appreciate the efforts to allow these features. For
audiobook lovers and old time radio show lovers, your
firmware has made the archos jukebox the ultimate dream
player. Thanks!!

Anonymous Submitter commented on 2003-06-23 18:26

Is there a new version of the compiled bookmark enabled
firmware available? I’ve tried all the URLs below

Garrett Derner commented on 2003-06-27 15:31

I did 2003-06-26 builds which include both my text viewer
patch and Ben’s bookmarking patch:

http://www.adfreeinternet.com/~garyd/rockbox/

Lee Pilgrim commented on 2003-08-04 21:03

Could you please update this patch. It dosen’t apply without
some work now.

Anonymous Submitter commented on 2003-11-05 08:50

bug report :
It cannot bookmark on recursively, dynamically generated
playlists on archos Recorder. For instance I use On+Play on a
folder, choose insert. Then it’s playing music, bookmarks
cannot be used.

Benjamin Metzler commented on 2003-11-05 20:35

Dynamic playlists are not supported. They are by nature
dynamic (changable) and therefor bookmarking them would
prove futile.

Anonymous Submitter commented on 2003-12-22 15:49

will somebody please FINISH this???!!

Blue Chip commented on 2004-01-12 07:46

I also listen to a LOT of spoken-word audio, and would love to
see this modification included in Rockbox.

Admin
Björn Stenberg commented on 2004-01-12 08:34

All major issues with this patch are now resolved and we’re
currently just ironing out a few final things before it goes
in.

Stay tuned.

Admin
Björn Stenberg commented on 2004-01-14 08:04

Committed.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing