• Status Unconfirmed
  • Percent Complete
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 3
  • Private
Attached to Project: Rockbox
Opened by GRaTT - 2007-09-08
Last edited by pondlife - 2007-10-10

FS#7729 - adds delete option to menu for jpeg viewer

Delete current file from within the jpeg viewer plugin.
Adds delete to the options in the menu
Also highlights the last file viewed in the file browser on quit.

GRaTT commented on 2007-09-08 15:35

Plugin now exits after delete of last file.

GRaTT commented on 2007-09-08 15:36

Here is the patch

nls commented on 2007-09-08 16:14

That last patch includes lots of unrelated changes

GRaTT commented on 2007-09-08 17:35

Sorry about that here is jpeg_delete1.1.diff
only jpeg stuff.

nls commented on 2007-09-09 13:00

I tried the patch and I do not like the two splashes that follow each other when you try to delete a file, I think you should do something like the delete_handler() function in onplay.c maybe just adding that function to the plugin api would be easiest and would also make the ui more consistent.

When deleting a file and try to jump to the next I sometimes got "err opening /G: -1" and sometimes right after deleting "unsupported" splashed for files which are supported and view just fine.

This was all on the simulator for iriver h300.

GRaTT commented on 2007-09-09 22:21

Fixed the delete menu, no more splashes.
Error handling fixed, does no try to open deleted file.
Tested on target sansa and in sim.

Good one. Works fine. I like the feature.

GRaTT commented on 2007-10-10 05:36

Some small changes to the delete screen
to make it more like the delete_handler
I could not successfully use delete_handler
function in plugin.c/h. Trouble with static.

Any chance someone wants to adapt this patch to the split up jpeg plugin?

GRaTT commented on 2009-03-20 05:26

Updated for the split up jpeg plugin.
Two patches
jpeg_delete1.4.diff just the delete option,
jpeg-rotate-delete1.0.diff includes fs#9497 the rotate option.

GRaTT commented on 2009-06-20 05:27

updated for June 19 2009 Version: r21362M-090620
menu changes.

Thank you.


Available keyboard shortcuts


Task Details

Task Editing