- Status Unconfirmed
- Percent Complete
- Task Type Patches
- Category Plugins
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes 3
- Private
FS#7729 - adds delete option to menu for jpeg viewer
Delete current file from within the jpeg viewer plugin.
Adds delete to the options in the menu
Also highlights the last file viewed in the file browser on quit.
GRaTT
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Plugin now exits after delete of last file.
GRaTT
Here is the patch
That last patch includes lots of unrelated changes
Sorry about that here is jpeg_delete1.1.diff
only jpeg stuff.
GRaTT
I tried the patch and I do not like the two splashes that follow each other when you try to delete a file, I think you should do something like the delete_handler() function in onplay.c maybe just adding that function to the plugin api would be easiest and would also make the ui more consistent.
When deleting a file and try to jump to the next I sometimes got "err opening /G: -1" and sometimes right after deleting "unsupported" splashed for files which are supported and view just fine.
This was all on the simulator for iriver h300.
Fixed the delete menu, no more splashes.
Error handling fixed, does no try to open deleted file.
Tested on target sansa and in sim.
GRaTT
Good one. Works fine. I like the feature.
Some small changes to the delete screen
to make it more like the delete_handler
screen.
I could not successfully use delete_handler
function in plugin.c/h. Trouble with static.
GRaTT
Any chance someone wants to adapt this patch to the split up jpeg plugin?
Updated for the split up jpeg plugin.
Two patches
jpeg_delete1.4.diff just the delete option,
jpeg-rotate-delete1.0.diff includes fs#9497 the rotate option.
GRaTT
updated for June 19 2009 Version: r21362M-090620
menu changes.
GRaTT
Thank you.