Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Catalin Patulea - 2007-09-10
Last edited by amiconn - 2007-09-11

FS#7748 - Fix svnversion.sh for localization and failure corner-cases

There were two problems with svnversion.sh@14659:
- If it was run on a machine with localization set to anything other than 

 English, the comparison to "exported" would get confused and print something
 like "rexportiert -070910". This caused build problems because the string
 isn't quoted before being passed to gcc.

- If svnversion fails (such as when invoked with a non-existent directory), 

 the output would look like "r-070910" because svnversion.sh didn't check for
 command failure.

This patch fixes both issues, and refactors svnversion error and output handling
into a shell functions.

Thanks to Rincewind, GodEater_ and amiconn for discovering the bug, helping fix
it and test the fix.

   rockbox-svnversion-locales-an... (2.3 KiB)
Closed by  amiconn
2007-09-11 05:11
Reason for closing:  Accepted
Catalin Patulea commented on 2007-09-10 20:26

Minimal (quick-n-dirty) version of original path.

   rockbox-svnversion-locales-an... (1.8 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing