FS#7748 : Fix svnversion.sh for localization and failure corner-cases

FS#7748 - Fix svnversion.sh for localization and failure corner-cases

Attached to Project: Rockbox
Opened by Catalin Patulea (Catalin Patulea) - Monday, 10 September 2007, 18:01 GMT
Last edited by Jens Arnold (amiconn) - Tuesday, 11 September 2007, 05:11 GMT

Task Type	Patches
Category	Build environment
Status	Closed
Assigned To	No-one
Operating System	All players
Severity	Low
Priority	Normal
Reported Version	Daily build (which?)
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	0
Private	No

Details

There were two problems with svnversion.sh@14659:
- If it was run on a machine with localization set to anything other than
English, the comparison to "exported" would get confused and print something
like "rexportiert -070910". This caused build problems because the string
isn't quoted before being passed to gcc.
- If svnversion fails (such as when invoked with a non-existent directory),
the output would look like "r-070910" because svnversion.sh didn't check for
command failure.

This patch fixes both issues, and refactors svnversion error and output handling
into a shell functions.

Thanks to Rincewind, GodEater_ and amiconn for discovering the bug, helping fix
it and test the fix.

rockbox-svnversion-locales-an... (2.3 KiB)

This task depends upon

Closed by Jens Arnold (amiconn)
Tuesday, 11 September 2007, 05:11 GMT
Reason for closing: Accepted

Comments (1)
Related Tasks (0/0)

Comment by Catalin Patulea (Catalin Patulea) - Monday, 10 September 2007, 20:26 GMT

Minimal (quick-n-dirty) version of original path.

rockbox-svnversion-locales-an... (1.8 KiB)

	Tasks related to this task (0)

Duplicate tasks of this task (0)

Rockbox

FS#7748 - Fix svnversion.sh for localization and failure corner-cases

Details

Loading...